Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(type-utils): fixed TypeOrValueSpecifier not accounting for scoped DT packages#6780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 8 commits intotypescript-eslint:v6frommarekdedic:type-or-value-specifier-scoped-packages
Apr 17, 2023
Merged

fix(type-utils): fixed TypeOrValueSpecifier not accounting for scoped DT packages#6780

JoshuaKGoldberg merged 8 commits intotypescript-eslint:v6frommarekdedic:type-or-value-specifier-scoped-packages
Apr 17, 2023

Conversation

marekdedic
Copy link
Contributor

@marekdedicmarekdedic commentedMar 27, 2023•
edited
Loading

PR Checklist

Overview

  • Added TypeOrValueSPecifier tests for package specifiers

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@marekdedic!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMar 27, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commite97628f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/643d30c81540080008b89f90
😎 Deploy Previewhttps://deploy-preview-6780--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Comment on lines +142 to +143
(ast.body[ast.body.length - 1] as TSESTree.TSTypeAliasDeclaration)
.id,
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I actually think this fixes a minor issue that is probably present in more tests - I have taken this directly out of some other tests in this repo

@nx-cloud
Copy link

nx-cloudbot commentedMar 27, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite97628f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

@marekdedicmarekdedic changed the titlefix(type-utils): fixed TypeOrValueSpecifier not accounting for org-scoped DT packagesfix(type-utils): fixed TypeOrValueSpecifier not accounting for scoped DT packagesMar 27, 2023
@marekdedicmarekdedic marked this pull request as ready for reviewMarch 27, 2023 21:41
@bradzacherbradzacher added the bugSomething isn't working labelApr 10, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM in general, thanks for the fast follow! Just requesting changes on 1-2 cleanups, lmk what you think?

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelApr 16, 2023
@codecov
Copy link

codecovbot commentedApr 17, 2023

Codecov Report

Merging#6780 (e97628f) intov6 (8a2752f) willincrease coverage by0.14%.
The diff coverage is100.00%.

Additional details and impacted files
@@            Coverage Diff             @@##               v6    #6780      +/-   ##==========================================+ Coverage   87.36%   87.51%   +0.14%==========================================  Files         373      376       +3       Lines       12800    12940     +140       Branches     3793     3820      +27     ==========================================+ Hits        11183    11324     +141+ Misses       1232     1231       -1  Partials      385      385
FlagCoverage Δ
unittest87.51% <100.00%> (+0.14%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/type-utils/src/TypeOrValueSpecifier.ts90.32% <100.00%> (+1.03%)⬆️

... and15 files with indirect coverage changes

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 great, thanks!

Weird puppet saying hooray

marekdedic reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldberg removed the awaiting responseIssues waiting for a reply from the OP or another party labelApr 17, 2023
@JoshuaKGoldbergJoshuaKGoldberg merged commit3350940 intotypescript-eslint:v6Apr 17, 2023
@marekdedicmarekdedic deleted the type-or-value-specifier-scoped-packages branchApril 17, 2023 15:03
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 25, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
bugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@marekdedic@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp