TypeError: e.getTypeArguments is not a functionOccurred while linting<input>:4Rule:"@typescript-eslint/no-unsafe-argument"    at FunctionSignature.create (https://typescript-eslint.io/sandbox/index.js:20:1047289)    at CallExpression, NewExpression (https://typescript-eslint.io/sandbox/index.js:20:1048838)    at https://typescript-eslint.io/sandbox/index.js:20:259967    at https://typescript-eslint.io/sandbox/index.js:20:250486    at Array.forEach (<anonymous>)    at Object.emit (https://typescript-eslint.io/sandbox/index.js:20:250474)    at NodeEventGenerator$1.applySelector (https://typescript-eslint.io/sandbox/index.js:4:122618)    at NodeEventGenerator$1.applySelectors (https://typescript-eslint.io/sandbox/index.js:4:122920)    at NodeEventGenerator$1.enterNode (https://typescript-eslint.io/sandbox/index.js:4:123011)    at CodePathAnalyzer$1.enterNode (https://typescript-eslint.io/sandbox/index.js:4:56566)

no-unsafe-argument

playground main
playground this branch

/*eslint "@typescript-eslint/no-unsafe-argument": "error"*/declarefunctionfoo(...params:[number,string,any]):void;foo(1,'a',1asany);

no-misused-promises

playground main
playground this branch

/*eslint "@typescript-eslint/no-misused-promises": "error"*/declarefunctionfoo(...params:[number]):void;foo(1);

require-array-sort-compare

playground main
playground this branch

/*eslint "@typescript-eslint/require-array-sort-compare": ["error", { "ignoreStringArrays": true }] */functionf(a:string[]){a.sort();}

note: type rules are not working on ts 3.3 this is most likely related to playground bug tho

ref#1752

fix: correct crashes with getTypeArguments for ts < 3.7

8f47a06

This comment was marked as resolved.

Copy link

netlifybot commentedMar 25, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`f678b6d`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/642130e61d09360008281fad
😎 Deploy Preview	https://deploy-preview-6767--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

nx-cloudbot commentedMar 25, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf678b6d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedMar 25, 2023•
edited
Loading

Codecov Report

Merging#6767 (8f47a06) intomain (f5631e9) willincrease coverage by0.03%.
The diff coverage is100.00%.

❗ Current head8f47a06 differs from pull request most recent headf678b6d. Consider uploading reports for the commitf678b6d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##             main    #6767      +/-   ##==========================================+ Coverage   87.29%   87.33%   +0.03%==========================================  Files         384      384                Lines       13139    13139                Branches     3859     3857       -2     ==========================================+ Hits        11470    11475       +5+ Misses       1302     1298       -4+ Partials      367      366       -1

Flag	Coverage Δ
unittest	`87.33% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts	`97.47% <100.00%> (ø)`
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts	`83.95% <100.00%> (ø)`
...int-plugin/src/rules/require-array-sort-compare.ts	`88.23% <100.00%> (ø)`
packages/type-utils/src/isTypeReadonly.ts	`88.00% <100.00%> (+2.00%)`	⬆️

... and1 file with indirect coverage changes

armano2 changed the title~~fix: correct crashes with getTypeArguments for ts < 3.7~~fix(eslint-plugin): correct crashes with getTypeArguments for ts < 3.7

Mar 25, 2023

armano2 added bug

Something isn't working

package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin labels

Mar 25, 2023

JoshuaKGoldberg approved these changes

Mar 25, 2023

View reviewed changes

bradzacher reviewed

Mar 25, 2023

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think that this isn't really necessary any more - we're about to merge our v6 that will bump the minimum we'll past 3.7

Also given nobody has reported this it's probably not worth adding in the inconsistency into the codebase just to fill the gap for a few weeks? WDYT?

Copy link

CollaboratorAuthor

armano2 commentedMar 26, 2023•
edited
Loading

I think that this isn't really necessary any more - we're about to merge our v6 that will bump the minimum we'll past 3.7
Also given nobody has reported this it's probably not worth adding in the inconsistency into the codebase just to fill the gap for a few weeks? WDYT?

as we still support this in current version its better to fix this now, that have ppl ask about this in feature,

util.getTypeArguments should be removed / deprecated in v6

Copy link

Member

bradzacher commentedMar 26, 2023

that have ppl ask about this in feature

That's kind of my point - 3.7 is 3 years old - so a lot of these have built up in the codebase over the last 3 years and I don't believe we've gotten one report about breakages.

There's some 250k weekly downloads for 3.7 versions (0.6% of the TS user base) and that number is likely dwindling. People aren't going to migrate onto 3.7 - and people that are using it certainly won't be using the latest version of our tooling.

Put another way - the intersection of people that are on the latest version of our tooling and the people that use TS3.7 is likely exactly 0.

bradzacher approved these changes

Mar 26, 2023

View reviewed changes

Merge branch 'main' into fix/crash-getTypeArguments-ts-3.7

f678b6d

armano2 merged commit59eab58 intomain

Mar 27, 2023

armano2 deleted the fix/crash-getTypeArguments-ts-3.7 branch

March 27, 2023 06:14

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request

Mar 28, 2023

Update typescript-eslint monorepo to v5.57.0 (#1831)

64ca05e

This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.56.0` -> `5.57.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.56.0/5.57.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.56.0` -> `5.57.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.56.0/5.57.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.57.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5570-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5560v5570-2023-03-27)[Compare Source](typescript-eslint/typescript-eslint@v5.56.0...v5.57.0)##### Bug Fixes-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] simplify fixer and add support for double negation ([#&#8203;6620](typescript-eslint/typescript-eslint#6620)) ([81c8519](typescript-eslint/typescript-eslint@81c8519))-   **eslint-plugin:** correct crashes with getTypeArguments for ts < 3.7 ([#&#8203;6767](typescript-eslint/typescript-eslint#6767)) ([59eab58](typescript-eslint/typescript-eslint@59eab58))##### Features-   **eslint-plugin:** \[consistent-type-assertions] add suggestions for objectLiteralTypeAssertions ([#&#8203;6642](typescript-eslint/typescript-eslint#6642)) ([720e811](typescript-eslint/typescript-eslint@720e811))-   **eslint-plugin:** \[consistent-type-assertions] autofix angle bracket assertions to as ([#&#8203;6641](typescript-eslint/typescript-eslint#6641)) ([ad8ea64](typescript-eslint/typescript-eslint@ad8ea64))-   **eslint-plugin:** add `no-duplicate-type-constituents` rule ([#&#8203;5728](typescript-eslint/typescript-eslint#5728)) ([bc31078](typescript-eslint/typescript-eslint@bc31078))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.57.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5570-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5560v5570-2023-03-27)[Compare Source](typescript-eslint/typescript-eslint@v5.56.0...v5.57.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMjQuMiJ9-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1831Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>