Jul 16, 2023 · Mar 24, 2023 · Apr 16, 2023 · Apr 16, 2023 · Apr 16, 2023 · Apr 16, 2023
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
          # Sadly 1 day is the minimum
          retention-days: 1

  unit_tests_tsserver:
    name: Run Unit Tests with Experimental TSServer
    needs: [build]
    runs-on: ubuntu-latest
    strategy:
      matrix:
        package:
          [
            'eslint-plugin',
            'eslint-plugin-internal',
            'eslint-plugin-tslint',
            'typescript-estree',
          ]
    env:
      COLLECT_COVERAGE: false
    steps:
      - name: Checkout
        uses: actions/checkout@v3
        with:
          fetch-depth: 2
      - name: Install
        uses: ./.github/actions/prepare-install
        with:
          node-version: 18
      - name: Build
        uses: ./.github/actions/prepare-build
      - name: Run unit tests for ${{ matrix.package }}
        run: npx nx test ${{ matrix.package }} --coverage=false
        env:
          CI: true
          TYPESCRIPT_ESLINT_EXPERIMENTAL_TSSERVER: true

  website_tests:
    # The NETLIFY_TOKEN secret will not be available on forks
    if: github.repository_owner == 'typescript-eslint'
diff --git a/.vscode/launch.json b/.vscode/launch.json
        "${workspaceFolder}/packages/scope-manager/dist/index.js",
      ],
    },
    {
      "type": "node",
      "request": "launch",
      "name": "Jest Test Current eslint-plugin-tslint Rule",
      "cwd": "${workspaceFolder}/packages/eslint-plugin-tslint/",
      "program": "${workspaceFolder}/node_modules/jest/bin/jest.js",
      "args": [
        "--runInBand",
        "--no-cache",
        "--no-coverage",
        "${fileBasenameNoExtension}"
      ],
      "sourceMaps": true,
      "console": "integratedTerminal",
      "internalConsoleOptions": "neverOpen",
      "skipFiles": [
        "${workspaceFolder}/packages/utils/src/index.ts",
        "${workspaceFolder}/packages/utils/dist/index.js",
        "${workspaceFolder}/packages/utils/src/ts-estree.ts",
        "${workspaceFolder}/packages/utils/dist/ts-estree.js",
        "${workspaceFolder}/packages/type-utils/src/index.ts",
        "${workspaceFolder}/packages/type-utils/dist/index.js",
        "${workspaceFolder}/packages/parser/src/index.ts",
        "${workspaceFolder}/packages/parser/dist/index.js",
        "${workspaceFolder}/packages/typescript-estree/src/index.ts",
        "${workspaceFolder}/packages/typescript-estree/dist/index.js",
        "${workspaceFolder}/packages/types/src/index.ts",
        "${workspaceFolder}/packages/types/dist/index.js",
        "${workspaceFolder}/packages/visitor-keys/src/index.ts",
        "${workspaceFolder}/packages/visitor-keys/dist/index.js",
        "${workspaceFolder}/packages/scope-manager/dist/index.js",
        "${workspaceFolder}/packages/scope-manager/dist/index.js",
      ],
    },
    {
      "type": "node",
      "request": "launch",
diff --git a/docs/packages/TypeScript_ESTree.mdx b/docs/packages/TypeScript_ESTree.mdx
   */
  errorOnTypeScriptSyntacticAndSemanticIssues?: boolean;

  /**
   * ***EXPERIMENTAL FLAG*** - Use this at your own risk.
   *
   * Whether to create a shared TypeScript server to power program creation.
   *
   * @see https://github.com/typescript-eslint/typescript-eslint/issues/6575
   */
  EXPERIMENTAL_useProjectService?: boolean;

  /**
   * ***EXPERIMENTAL FLAG*** - Use this at your own risk.
   *
   *
   * This flag REQUIRES at least TS v3.9, otherwise it does nothing.
   *
   *See: https://github.com/typescript-eslint/typescript-eslint/issues/2094
   *@see https://github.com/typescript-eslint/typescript-eslint/issues/2094
   */
  EXPERIMENTAL_useSourceOfProjectReferenceRedirect?: boolean;

diff --git a/packages/eslint-plugin-tslint/src/rules/config.ts b/packages/eslint-plugin-tslint/src/rules/config.ts
 import { ESLintUtils } from '@typescript-eslint/utils';
 import path from 'path';
 import type { RuleSeverity } from 'tslint';
 import { Configuration } from 'tslint';

    context,
    [{ rules: tslintRules, rulesDirectory: tslintRulesDirectory, lintFile }],
  ) {
    const fileName = context.getFilename();
    const fileName =path.resolve(context.getCwd(), context.getFilename());
    const sourceCode = context.getSourceCode().text;
    const services = ESLintUtils.getParserServices(context);
    const program = services.program;
diff --git a/packages/eslint-plugin/tests/rules/consistent-type-imports.test.ts b/packages/eslint-plugin/tests/rules/consistent-type-imports.test.ts
 });

 const withMetaParserOptions = {
  EXPERIMENTAL_useProjectService: false,
  tsconfigRootDir: getFixturesRootDir(),
  project: './tsconfig-withmeta.json',
 };
diff --git a/packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts b/packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts
 }
      `,
      parserOptions: {
        EXPERIMENTAL_useProjectService: false,
        tsconfigRootDir: getFixturesRootDir(),
        project: './tsconfig.noUncheckedIndexedAccess.json',
      },
diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts
 const ruleTester = new RuleTester({
  parser: '@typescript-eslint/parser',
  parserOptions: {
    EXPERIMENTAL_useProjectService: false,
    project: './tsconfig.noImplicitThis.json',
    tsconfigRootDir: getFixturesRootDir(),
  },
diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-call.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-call.test.ts
 const ruleTester = new RuleTester({
  parser: '@typescript-eslint/parser',
  parserOptions: {
    EXPERIMENTAL_useProjectService: false,
    project: './tsconfig.noImplicitThis.json',
    tsconfigRootDir: getFixturesRootDir(),
  },
diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-member-access.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-member-access.test.ts
 const ruleTester = new RuleTester({
  parser: '@typescript-eslint/parser',
  parserOptions: {
    EXPERIMENTAL_useProjectService: false,
    project: './tsconfig.noImplicitThis.json',
    tsconfigRootDir: getFixturesRootDir(),
  },
diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-return.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-return.test.ts
 const ruleTester = new RuleTester({
  parser: '@typescript-eslint/parser',
  parserOptions: {
    EXPERIMENTAL_useProjectService: false,
    project: './tsconfig.noImplicitThis.json',
    tsconfigRootDir: getFixturesRootDir(),
  },
diff --git a/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts b/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts
 });

 const withMetaParserOptions = {
  EXPERIMENTAL_useProjectService: false,
  tsconfigRootDir: getFixturesRootDir(),
  project: './tsconfig-withmeta.json',
 };
diff --git a/packages/eslint-plugin/tests/rules/non-nullable-type-assertion-style.test.ts b/packages/eslint-plugin/tests/rules/non-nullable-type-assertion-style.test.ts

 const ruleTesterWithNoUncheckedIndexAccess = new RuleTester({
  parserOptions: {
    EXPERIMENTAL_useProjectService: false,
    sourceType: 'module',
    tsconfigRootDir: getFixturesRootDir(),
    project: './tsconfig.noUncheckedIndexedAccess.json',
diff --git a/packages/parser/tests/lib/parser.ts b/packages/parser/tests/lib/parser.ts
 import * as scopeManager from '@typescript-eslint/scope-manager';
 import type { ParserOptions } from '@typescript-eslint/types';
 import * as typescriptESTree from '@typescript-eslint/typescript-estree';
 import path from 'path';

 import { parse, parseForESLint } from '../../src/parser';

        jsx: false,
      },
      // ts-estree specific
      filePath: 'isolated-file.src.ts',
      filePath: './isolated-file.src.ts',
      project: 'tsconfig.json',
      errorOnTypeScriptSyntacticAndSemanticIssues: false,
      tsconfigRootDir:'tests/fixtures/services',
      tsconfigRootDir:path.resolve(__dirname, '../fixtures/services'),
      extraFileExtensions: ['.foo'],
    };
    parseForESLint(code, config);
      filePath: 'isolated-file.src.ts',
      project: 'tsconfig.json',
      errorOnTypeScriptSyntacticAndSemanticIssues: false,
      tsconfigRootDir:'tests/fixtures/services',
      tsconfigRootDir:path.join(__dirname, '../fixtures/services'),
      extraFileExtensions: ['.foo'],
    };
    parseForESLint(code, config);
diff --git a/packages/rule-tester/tests/RuleTester.test.ts b/packages/rule-tester/tests/RuleTester.test.ts
          {
            code: 'type-aware parser options should override the constructor config',
            parserOptions: {
              EXPERIMENTAL_useProjectService: false,
              project: 'tsconfig.test-specific.json',
              tsconfigRootDir: '/set/in/the/test/',
            },
            "code": "type-aware parser options should override the constructor config",
            "filename": "/set/in/the/test/file.ts",
            "parserOptions": {
              "EXPERIMENTAL_useProjectService": false,
              "project": "tsconfig.test-specific.json",
              "tsconfigRootDir": "/set/in/the/test/",
            },
diff --git a/packages/type-utils/tests/TypeOrValueSpecifier.test.ts b/packages/type-utils/tests/TypeOrValueSpecifier.test.ts
      ],
      [
        'interface Foo {prop: string}; type Test = Foo;',
        { from: 'file', name: 'Foo', path: 'tests/fixtures/file.ts' },
        { from: 'file', name: 'Foo', path: 'file.ts' },
      ],
      [
        'type Foo = {prop: string}; type Test = Foo;',
        { from: 'file', name: 'Foo', path: 'tests/fixtures/file.ts' },
        { from: 'file', name: 'Foo', path: 'file.ts' },
      ],
      [
        'interface Foo {prop: string}; type Test = Foo;',
        {
          from: 'file',
          name: 'Foo',
          path: 'tests/../tests/fixtures/////file.ts',
          path: './////file.ts',
        },
      ],
      [
        'type Foo = {prop: string}; type Test = Foo;',
        {
          from: 'file',
          name: 'Foo',
          path: 'tests/../tests/fixtures/////file.ts',
          path: './////file.ts',
        },
      ],
      [
        'interface Foo {prop: string}; type Test = Foo;',
        {
          from: 'file',
          name: ['Foo', 'Bar'],
          path: 'tests/fixtures/file.ts',
          path: 'file.ts',
        },
      ],
      [
        'type Foo = {prop: string}; type Test = Foo;',
        {
          from: 'file',
          name: ['Foo', 'Bar'],
          path: 'tests/fixtures/file.ts',
          path: 'file.ts',
        },
      ],
    ])('matches a matching file specifier: %s', runTestPositive);
      ],
      [
        'interface Foo {prop: string}; type Test = Foo;',
        { from: 'file', name: 'Foo', path: 'tests/fixtures/wrong-file.ts' },
        { from: 'file', name: 'Foo', path: 'wrong-file.ts' },
      ],
      [
        'interface Foo {prop: string}; type Test = Foo;',
        {
          from: 'file',
          name: ['Foo', 'Bar'],
          path: 'tests/fixtures/wrong-file.ts',
          path: 'wrong-file.ts',
        },
      ],
    ])("doesn't match a mismatched file specifier: %s", runTestNegative);
      ['type Test = RegExp;', { from: 'file', name: ['RegExp', 'BigInt'] }],
      [
        'type Test = RegExp;',
        { from: 'file', name: 'RegExp', path: 'tests/fixtures/file.ts' },
        { from: 'file', name: 'RegExp', path: 'file.ts' },
      ],
      [
        'type Test = RegExp;',
        {
          from: 'file',
          name: ['RegExp', 'BigInt'],
          path: 'tests/fixtures/file.ts',
          path: 'file.ts',
        },
      ],
      [
diff --git a/packages/types/src/parser-options.ts b/packages/types/src/parser-options.ts
  debugLevel?: DebugLevel;
  errorOnTypeScriptSyntacticAndSemanticIssues?: boolean;
  errorOnUnknownASTType?: boolean;
  EXPERIMENTAL_useProjectService?: boolean; // purposely undocumented for now
  EXPERIMENTAL_useSourceOfProjectReferenceRedirect?: boolean; // purposely undocumented for now
  extraFileExtensions?: string[];
  filePath?: string;
diff --git a/packages/typescript-estree/src/clear-caches.ts b/packages/typescript-estree/src/clear-caches.ts
 import { clearWatchCaches } from './create-program/getWatchProgramsForProjects';
 import { clearProgramCache as clearProgramCacheOriginal } from './parser';
 import { clearTSConfigMatchCache } from './parseSettings/createParseSettings';
 import {
  clearTSConfigMatchCache,
  clearTSServerProjectService,
 } from './parseSettings/createParseSettings';
 import { clearGlobCache } from './parseSettings/resolveProjectList';

 /**
  clearProgramCacheOriginal();
  clearWatchCaches();
  clearTSConfigMatchCache();
  clearTSServerProjectService();
  clearGlobCache();
 }

diff --git a/packages/typescript-estree/src/create-program/createProjectProgram.ts b/packages/typescript-estree/src/create-program/createProjectProgram.ts
 import { firstDefined } from '../node-utils';
 import type { ParseSettings } from '../parseSettings';
 import { describeFilePath } from './describeFilePath';
 import { getWatchProgramsForProjects } from './getWatchProgramsForProjects';
 import type { ASTAndDefiniteProgram } from './shared';
 import { getAstFromProgram } from './shared';

 */
 function createProjectProgram(
  parseSettings: ParseSettings,
  programsForProjects: readonly ts.Program[],
 ): ASTAndDefiniteProgram | undefined {
  log('Creating project program for: %s', parseSettings.filePath);

  const programsForProjects = getWatchProgramsForProjects(parseSettings);
  const astAndProgram = firstDefined(programsForProjects, currentProgram =>
    getAstFromProgram(currentProgram, parseSettings),
    getAstFromProgram(currentProgram, parseSettings.filePath),
  );

  // The file was either matched within the tsconfig, or we allow creating a default program
Original file line number	Diff line number	Diff line change
Expand Up		@@ -193,6 +193,38 @@ jobs:
		# Sadly 1 day is the minimum
		retention-days: 1

		unit_tests_tsserver:
		name: Run Unit Tests with Experimental TSServer
		needs: [build]
		runs-on: ubuntu-latest
		strategy:
		matrix:
		package:
		[
		'eslint-plugin',
		'eslint-plugin-internal',
		'eslint-plugin-tslint',
		'typescript-estree',
		]
		env:
		COLLECT_COVERAGE: false
		steps:
		- name: Checkout
		uses: actions/checkout@v3
		with:
		fetch-depth: 2
		- name: Install
		uses: ./.github/actions/prepare-install
		with:
		node-version: 18
		- name: Build
		uses: ./.github/actions/prepare-build
		- name: Run unit tests for ${{ matrix.package }}
		run: npx nx test ${{ matrix.package }} --coverage=false
		env:
		CI: true
		TYPESCRIPT_ESLINT_EXPERIMENTAL_TSSERVER: true
Comment on lines +196 to +226 Copy link Member bradzacherJul 17, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This was a great thing to add!

		website_tests:
		# The NETLIFY_TOKEN secret will not be available on forks
		if: github.repository_owner == 'typescript-eslint'
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -141,6 +141,40 @@
		"${workspaceFolder}/packages/scope-manager/dist/index.js",
		],
		},
		{
		"type": "node",
		"request": "launch",
		"name": "Jest Test Current eslint-plugin-tslint Rule",
		"cwd": "${workspaceFolder}/packages/eslint-plugin-tslint/",
		"program": "${workspaceFolder}/node_modules/jest/bin/jest.js",
		"args": [
		"--runInBand",
		"--no-cache",
		"--no-coverage",
		"${fileBasenameNoExtension}"
		],
		"sourceMaps": true,
		"console": "integratedTerminal",
		"internalConsoleOptions": "neverOpen",
		"skipFiles": [
		"${workspaceFolder}/packages/utils/src/index.ts",
		"${workspaceFolder}/packages/utils/dist/index.js",
		"${workspaceFolder}/packages/utils/src/ts-estree.ts",
		"${workspaceFolder}/packages/utils/dist/ts-estree.js",
		"${workspaceFolder}/packages/type-utils/src/index.ts",
		"${workspaceFolder}/packages/type-utils/dist/index.js",
		"${workspaceFolder}/packages/parser/src/index.ts",
		"${workspaceFolder}/packages/parser/dist/index.js",
		"${workspaceFolder}/packages/typescript-estree/src/index.ts",
		"${workspaceFolder}/packages/typescript-estree/dist/index.js",
		"${workspaceFolder}/packages/types/src/index.ts",
		"${workspaceFolder}/packages/types/dist/index.js",
		"${workspaceFolder}/packages/visitor-keys/src/index.ts",
		"${workspaceFolder}/packages/visitor-keys/dist/index.js",
		"${workspaceFolder}/packages/scope-manager/dist/index.js",
		"${workspaceFolder}/packages/scope-manager/dist/index.js",
		],
		},
		{
		"type": "node",
		"request": "launch",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -147,6 +147,15 @@ interface ParseAndGenerateServicesOptions extends ParseOptions {
		*/
		errorOnTypeScriptSyntacticAndSemanticIssues?: boolean;

		/**
		* *EXPERIMENTAL FLAG* - Use this at your own risk.
		*
		* Whether to create a shared TypeScript server to power program creation.
		*
		* @see https://github.com/typescript-eslint/typescript-eslint/issues/6575
		*/
		EXPERIMENTAL_useProjectService?: boolean;

		/**
		* *EXPERIMENTAL FLAG* - Use this at your own risk.
		*
Expand All		@@ -155,7 +164,7 @@ interface ParseAndGenerateServicesOptions extends ParseOptions {
		*
		* This flag REQUIRES at least TS v3.9, otherwise it does nothing.
		*
		*See: https://github.com/typescript-eslint/typescript-eslint/issues/2094
		*@see https://github.com/typescript-eslint/typescript-eslint/issues/2094
		*/
		EXPERIMENTAL_useSourceOfProjectReferenceRedirect?: boolean;

Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,5 @@
		import { ESLintUtils } from '@typescript-eslint/utils';
		import path from 'path';
		import type { RuleSeverity } from 'tslint';
		import { Configuration } from 'tslint';

Expand DownExpand Up		@@ -118,7 +119,7 @@ export default createRule<Options, MessageIds>({
		context,
		[{ rules: tslintRules, rulesDirectory: tslintRulesDirectory, lintFile }],
		) {
		const fileName = context.getFilename();
		const fileName =path.resolve(context.getCwd(), context.getFilename());
Copy link MemberAuthor JoshuaKGoldbergApr 27, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Explaining: with`EXPERIMENTAL_ProjectService`, relative paths might no longer match up with how the project views its root file. So switching to absolute paths is more reliable.
		const sourceCode = context.getSourceCode().text;
		const services = ESLintUtils.getParserServices(context);
		const program = services.program;
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -16,6 +16,7 @@ const ruleTester = new RuleTester({
		});

		const withMetaParserOptions = {
		EXPERIMENTAL_useProjectService: false,
JoshuaKGoldberg marked this conversation as resolved. Show resolvedHide resolved
		tsconfigRootDir: getFixturesRootDir(),
		project: './tsconfig-withmeta.json',
		};
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -595,6 +595,7 @@ function getElem(dict: Record<string, { foo: string }>, key: string) {
		}
		`,
		parserOptions: {
		EXPERIMENTAL_useProjectService: false,
		tsconfigRootDir: getFixturesRootDir(),
		project: './tsconfig.noUncheckedIndexedAccess.json',
		},
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -65,6 +65,7 @@ function assignmentTest(
		const ruleTester = new RuleTester({
		parser: '@typescript-eslint/parser',
		parserOptions: {
		EXPERIMENTAL_useProjectService: false,
		project: './tsconfig.noImplicitThis.json',
		tsconfigRootDir: getFixturesRootDir(),
		},
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,6 +6,7 @@ import { getFixturesRootDir } from '../RuleTester';
		const ruleTester = new RuleTester({
		parser: '@typescript-eslint/parser',
		parserOptions: {
		EXPERIMENTAL_useProjectService: false,
		project: './tsconfig.noImplicitThis.json',
		tsconfigRootDir: getFixturesRootDir(),
		},
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -14,6 +14,7 @@ const ruleTester = new RuleTester({
		});

		const withMetaParserOptions = {
		EXPERIMENTAL_useProjectService: false,
		tsconfigRootDir: getFixturesRootDir(),
		project: './tsconfig-withmeta.json',
		};
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -204,6 +204,7 @@ const y = x!;

		const ruleTesterWithNoUncheckedIndexAccess = new RuleTester({
		parserOptions: {
		EXPERIMENTAL_useProjectService: false,
		sourceType: 'module',
		tsconfigRootDir: getFixturesRootDir(),
		project: './tsconfig.noUncheckedIndexedAccess.json',
Expand Down