Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(website): [playground] improve design of error viewer#6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
armano2 merged 2 commits intov6fromchore/website-error-viewer-correct-design-issues
Mar 27, 2023

Conversation

armano2
Copy link
Collaborator

PR Checklist

Overview

migrate error viewer changes from#6656

notable changes:

  • alerts have consistent small spacing between them
  • text is printed as monospace font
  • text is wrapped

imageimage

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMar 22, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit613ff12
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/641b4c61eafdaa0008d97fba
😎 Deploy Previewhttps://deploy-preview-6738--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@nx-cloud
Copy link

nx-cloudbot commentedMar 22, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit613ff12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedMar 22, 2023
edited
Loading

Codecov Report

Merging#6738 (613ff12) intov6 (f84bf4a) willdecrease coverage by0.04%.
The diff coverage isn/a.

Additional details and impacted files
@@            Coverage Diff             @@##               v6    #6738      +/-   ##==========================================- Coverage   87.40%   87.36%   -0.04%==========================================  Files         373      373                Lines       12844    12800      -44       Branches     3811     3793      -18     ==========================================- Hits        11226    11183      -43  Misses       1232     1232+ Partials      386      385       -1
FlagCoverage Δ
unittest87.36% <ø> (-0.04%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like it!

@armano2armano2 changed the titlechore(website): improve design of error viewerchore(website): [playground] improve design of error viewerMar 26, 2023
@armano2armano2 merged commit45991b3 intov6Mar 27, 2023
@armano2armano2 deleted the chore/website-error-viewer-correct-design-issues branchMarch 27, 2023 07:25
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp