Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): update build script to use esbuild instead of rollup#6716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
armano2 merged 12 commits intov6fromchore/website-eslint-improve-build
Mar 30, 2023

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedMar 21, 2023•
edited
Loading

PR Checklist

Overview

those changes have been extracted from#6656

  • migrate from rollup to esbuild
  • correct source map generation
  • reduce bundle size
  • simplify build

stats

  • bundling website-eslint: 220.45ms
  • netlify build time: ~ -2m (if we remove building all packages)
  • package size: ~ -250kb
source maps

this branch

image

v6

image

evanw/esbuild#819

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMar 21, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit2d992dc
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6424f364c5947d00083985e1
😎 Deploy Previewhttps://deploy-preview-6716--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@bradzacher
Copy link
Member

ditto with#6656 - could we base this against the v6 branch?

armano2 reacted with thumbs up emoji

@armano2armano2 changed the base branch frommain tov6March 21, 2023 01:45
@nx-cloud
Copy link

nx-cloudbot commentedMar 21, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit2d992dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

@armano2armano2 changed the base branch fromv6 tomainMarch 21, 2023 01:57
@armano2armano2force-pushed thechore/website-eslint-improve-build branch from741eb84 to01b9f00CompareMarch 21, 2023 02:13
@armano2armano2 changed the base branch frommain tov6March 21, 2023 02:13
@armano2armano2 changed the titlechore(website-eslint): update build script to use esbuild instead of rollupchore(website): update build script to use esbuild instead of rollupMar 21, 2023
@codecov
Copy link

codecovbot commentedMar 21, 2023•
edited
Loading

Codecov Report

Merging#6716 (8c9a0cd) intov6 (6a307f0) willincrease coverage by2.21%.
The diff coverage isn/a.

❗ Current head8c9a0cd differs from pull request most recent head2d992dc. Consider uploading reports for the commit2d992dc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##               v6    #6716      +/-   ##==========================================+ Coverage   85.15%   87.36%   +2.21%==========================================  Files         383      373      -10       Lines       13026    12800     -226       Branches     3839     3793      -46     ==========================================+ Hits        11092    11183      +91+ Misses       1572     1232     -340- Partials      362      385      +23
FlagCoverage Δ
unittest87.36% <ø> (+2.21%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 163 files with indirect coverage changes

@armano2
Copy link
CollaboratorAuthor

@bradzacher i enabled type-checking forwebsite-eslint and updated build to use source code instead ofdist, I also removed most of no longer necessaryuse-at-your-own-risk as some of them where redundant and not really necessary

if you think that we should restore some of them let me know

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

remove the rollup config from renovate and we can land this

// TODO - once we bump pass the major, we can remove these. Currently renovate is creating broken, immortal PRs
'@rollup/plugin-babel',
'@rollup/plugin-commonjs',
'@rollup/plugin-json',
'@rollup/plugin-node-resolve',
'@rollup/plugin-replace',
'@rollup/plugin-terser',
'@rollup/pluginutils',
'rollup-plugin-terser',
'rollup',

{
matchPackagePrefixes:['@rollup','rollup-'],
matchPackageNames:['rollup'],
groupName:'rollup',
},

armano2 reacted with thumbs up emoji
@armano2armano2 merged commit4eb0e3a intov6Mar 30, 2023
@armano2armano2 deleted the chore/website-eslint-improve-build branchMarch 30, 2023 02:45
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@armano2@bradzacher@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp