Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(utils): add missing types for onCodePath* in RuleListener#6679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
armano2 wants to merge1 commit intomainfromfix/add-missing-definition-for-onX

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedMar 19, 2023•
edited by bradzacher
Loading

PR Checklist

Overview

Add missing type definition for events used incode path analysis

this should allow consumers use our types properly instead of having to use@ts-ignore

example:
https://github.com/SonarSource/eslint-plugin-sonarjs/blob/4dfd992eeccafca92caed52889b4f83bb1e38c3c/src/rules/no-one-iteration-loop.ts#L41

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMar 19, 2023•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commit6e4cf10
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6416ca2c4cfff70007c00db6

@armano2armano2 added the package: utilsIssues related to the @typescript-eslint/utils package labelMar 19, 2023
@armano2armano2 marked this pull request as ready for reviewMarch 19, 2023 08:39
@nx-cloud
Copy link

☁️ Nx Cloud Report

CI is running/has finished running commands for commit6e4cf10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
nx run-many --target=build --parallel --exclude website

Sent with 💌 fromNxCloud.

@armano2armano2 marked this pull request as draftMarch 19, 2023 09:09
@armano2armano2 deleted the fix/add-missing-definition-for-onX branchMarch 19, 2023 09:39
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 27, 2023
@armano2armano2 restored the fix/add-missing-definition-for-onX branchAugust 27, 2023 10:54
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
package: utilsIssues related to the @typescript-eslint/utils package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@armano2
[8]ページ先頭
©2009-2025 Movatter.jp