Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): [playground] add support for extends, ts types and more#6656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
armano2 wants to merge7 commits intomainfromfeat/playground-v2

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedMar 16, 2023•
edited
Loading

PR Checklist

Overview

New features

TODO: explain what changed

@armano2armano2 added package: websiteIssues related to the @typescript-eslint website website: playground labelsMar 16, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMar 16, 2023•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commit99af316
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6508f62c81750e00087f5cd4

@nx-cloud
Copy link

nx-cloudbot commentedMar 16, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit99af316. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
nx run-many --target=typecheck --parallel
nx build website
✅ Successfully ran 17 targets

Sent with 💌 fromNxCloud.

@armano2
Copy link
CollaboratorAuthor

@JoshuaKGoldberg when you find some time can you do preliminary review on this?
git generated way to many file changes :)

JoshuaKGoldberg reacted with thumbs up emojiJoshuaKGoldberg reacted with laugh emoji

@armano2armano2 marked this pull request as ready for reviewMarch 17, 2023 22:58
@armano2armano2 changed the titlechore(website): small improvements to playgroundchore(website): [playground] add support for extends, ts types and more..Mar 18, 2023
@armano2armano2 changed the titlechore(website): [playground] add support for extends, ts types and more..chore(website): [playground] add support for extends, ts types and moreMar 18, 2023
@JoshuaKGoldberg
Copy link
Member

I will... try 🥺 😅

@JoshuaKGoldberg
Copy link
Member

cc@jakebailey@orta - if either or both of you have time, this PR might be of interest to you. See in particular thepackages/website/src/components/linter/bridge.ts file for how we're using@typescript/vfs.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah@armano2 this is fantastic, really great stuff! It works smoothly and the new features (types, scopes, file type, ...) are awesome.

I mainly looked at how thePlaygroundRoot component along with the component & hooks it uses. Also the new build scripts.

My biggest point of feedback would be that if you can split up the changes at all that would be really helpful for reviewing. It's a big one 😄. But if not I think it's a direct step in many positive directions from the site today, and it'd be also great to work from what's here.

LMK when it's ready for a full review! 🙌

@armano2
Copy link
CollaboratorAuthor

armano2 commentedMar 21, 2023•
edited
Loading

I will try to split this PR up a little

@bradzacher
Copy link
Member

would it be possible to rebase this against thev6 branch?
There are a bunch of changes we've got in v6 to the website tools - so we don't want to accidentally get into a bad state and break things if we merge this intomain beforev6.

armano2 reacted with laugh emoji

@armano2
Copy link
CollaboratorAuthor

@bradzacher changes rebased

Base automatically changed fromv6 tomainJuly 10, 2023 17:52
@JoshuaKGoldberg
Copy link
Member

👋 ping@armano2, do you still have time / plans to work on this?

@JoshuaKGoldbergJoshuaKGoldberg added the stalePRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period labelJun 2, 2024
@JoshuaKGoldberg
Copy link
Member

Closing out this old draft PR to keep the queue small. 🧹

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 11, 2024
@armano2armano2 deleted the feat/playground-v2 branchJuly 22, 2024 17:08
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
package: websiteIssues related to the @typescript-eslint websitestalePRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged periodwebsite: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@armano2@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp