Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): [no-misused-promises] fix incorrect detection of void functions in JSX attributes#6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 2 commits intomainfrom6637-nmu-jsx-bug
Mar 15, 2023

Conversation

@bradzacher
Copy link
Member

PR Checklist

Overview

Dunno how this existed for so long!

@bradzacherbradzacher added the bugSomething isn't working labelMar 15, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMar 15, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit75500fc
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/64112a61124bbf00075e3d49
😎 Deploy Previewhttps://deploy-preview-6638--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@nx-cloud
Copy link

nx-cloudbot commentedMar 15, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit75500fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedMar 15, 2023

Codecov Report

Merging#6638 (75500fc) intomain (9eafd87) willnot change coverage.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #6638   +/-   ##=======================================  Coverage   85.15%   85.15%           =======================================  Files         383      383             Lines       13026    13026             Branches     3839     3839           =======================================  Hits        11092    11092             Misses       1572     1572             Partials      362      362
FlagCoverage Δ
unittest85.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts97.47% <100.00%> (ø)

@bradzacher
Copy link
MemberAuthor

need this for the v6 branch, so jumping the merge queue.

JoshuaKGoldberg reacted with thumbs up emoji

@bradzacherbradzacher merged commit9e41cee intomainMar 15, 2023
@bradzacherbradzacher deleted the 6637-nmu-jsx-bug branchMarch 15, 2023 22:17
hasparus pushed a commit to hasparus/typescript-eslint that referenced this pull requestMar 22, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 23, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [no-misused-promises] false positive with non-promise returning function in JSX

2 participants

@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp