fix(eslint-plugin): [no-confusing-void-expression] check sequence expressions for void is in last position#6597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromcparros:main

Mar 13, 2023

Merged

fix(eslint-plugin): [no-confusing-void-expression] check sequence expressions for void is in last position#6597

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromcparros:main

Mar 13, 2023

Conversation

Copy link

Contributor

cparros commentedMar 10, 2023

PR Checklist

Addresses an existing open issue:fixesBug: [@typescript-eslint/no-confusing-void-expression] report error when the void type expression is at the left of comma operators #6414
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Added a check to sequence expressions that ignores void unless it is in the last position of a SequenceExpression

Sequence expression check and tests

500c7e9

Copy link

nx-cloudbot commentedMar 10, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit500c7e9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedMar 10, 2023

Thanks for the PR,@cparros!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMar 10, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`500c7e9`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/640b93e747f8600008ca71ff
😎 Deploy Preview	https://deploy-preview-6597--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedMar 10, 2023•
edited
Loading

Codecov Report

Merging#6597 (500c7e9) intomain (006c86d) willincrease coverage by0.00%.
The diff coverage is100.00%.

Additional details and impacted files

@@           Coverage Diff           @@##             main    #6597   +/-   ##=======================================  Coverage   90.67%   90.67%           =======================================  Files         376      376             Lines       12849    12852    +3       Branches     3783     3785    +2     =======================================+ Hits        11651    11654    +3  Misses        854      854             Partials      344      344