fix: throw error on invalid`ThrowStatement`#6561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

fisker wants to merge1 commit intotypescript-eslint:v6fromfisker:invalid-throw

Closed

fix: throw error on invalid`ThrowStatement`#6561

fisker wants to merge1 commit intotypescript-eslint:v6fromfisker:invalid-throw

Conversation

Copy link

Contributor

fisker commentedMar 3, 2023

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Throw same error forthrow andthrow\n

Ref:#1852 (comment)

fix: throw error on invalidThrowStatement

bbf3815

Copy link

Contributor

typescript-eslintbot commentedMar 3, 2023

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloudbot commentedMar 3, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitbbf3815. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
`Node 14 - nx test typescript-estree --coverage=false`

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedMar 3, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`bbf3815`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64015bf8d7c4e800081ce9ab
😎 Deploy Preview	https://deploy-preview-6561--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.