typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

test(ast-spec): snapshot codeframe of error#6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intotypescript-eslint:v6fromfisker:snapshot-error

Mar 2, 2023

Merged

test(ast-spec): snapshot codeframe of error#6555

bradzacher merged 1 commit intotypescript-eslint:v6fromfisker:snapshot-error

Mar 2, 2023

Conversation

Copy link

Contributor

fisker commentedMar 2, 2023

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

During upgrade parser to v6 in Prettier, I found some error location should be improved, but before that, let's make the error visible?

test: snapshot codeframe of error

33a4fec

Copy link

nx-cloudbot commentedMar 2, 2023•
edited
Loading

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit33a4fec.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Checkthe Nx Cloud Github Integration documentation for more information.

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedMar 2, 2023

Thanks for the PR,@fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMar 2, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`33a4fec`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64001902a7308b000802f101
😎 Deploy Preview	https://deploy-preview-6555--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

bradzacher reviewed

Mar 2, 2023

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is a great idea!
I wonder if we should be capturing an end as well as part of theTSError?

That way we could throw errors on ranges instead of just on single characters.
Looks like code-frame also supports an end range, so we would even be able to snapshot it.

WDYT?