Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(eslint-plugin): add allowNever support to restrict-template-expressions#6554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(eslint-plugin): add allowNever support to restrict-template-expressions#6554
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nx-cloudbot commentedMar 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the PR,@domdomegg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedMar 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site settings. |
codecovbot commentedMar 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #6554 +/- ##==========================================+ Coverage 85.15% 85.17% +0.02%========================================== Files 383 383 Lines 13026 13035 +9 Branches 3839 3841 +2 ==========================================+ Hits 11092 11103 +11+ Misses 1572 1570 -2 Partials 362 362
Flags with carried forward coverage won't be shown.Click here to find out more.
|
domdomegg commentedMar 2, 2023
Hey@bradzacher - I think this PR is good to go but the 'Website tests' build is failing due to Netlify not being ready. I don't think I've changed anything meaningful here, and it seems also to be failing on main. I'm wary that the query listed in the contributing docs filters out this PR because of the failing status, and wanted to check this could still get reviewed. (apologies if you're the wrong person to ping - couldn't find a doc on process for these kinds of questions in the contributing docs) |
JoshuaKGoldberg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks nice and clean, thanks for sending this in@domdomegg! Just blocking on adding more tests (or pointing me to where I've missed them). 🚀
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
JoshuaKGoldberg commentedMar 8, 2023
Blurgh, yeah, this is unfortunate.#6508. Don't worry about it - it's out of your control and unrelated to this PR.
Looks like we need to clarify that! Thanks for mentioning@domdomegg 😄. Just filed#6584:
|
nx-cloudbot commentedMar 14, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit0a97df7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 25 targets
Sent with 💌 fromNxCloud. |
JoshuaKGoldberg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Super, thanks@domdomegg! ✨
JoshuaKGoldberg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Err, once the unit test failure is resolved, that is*
Summary of all failing tests FAIL tests/rules/restrict-template-expressions.test.ts ● restrict-template-expressions › invalid › declare const value: never; const stringy = `${value}`; assert.strictEqual(received, expected) Expected value to strictly be equal to: 26 Received: 28 Message: Error column should be 26JoshuaKGoldberg left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
awesome! Thanks@domdomegg!
…essions (typescript-eslint#6554)* feat(eslint-plugin): add allowNever support to restrict-template-expressions* Update tests* Fix lint issues* Fix test
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.54.0` -> `5.56.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.54.0/5.56.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.54.0` -> `5.56.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.54.0/5.56.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary>### [`v5.56.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5560-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5550v5560-2023-03-20)[Compare Source](typescript-eslint/typescript-eslint@v5.55.0...v5.56.0)##### Bug Fixes- **eslint-plugin:** \[member-ordering] check order when optionalityOrder is present with no optional members ([#​6619](typescript-eslint/typescript-eslint#6619)) ([6aff431](typescript-eslint/typescript-eslint@6aff431))- **eslint-plugin:** \[no-misused-promises] avoid unnecessary calls to getContextualType ([#​6193](typescript-eslint/typescript-eslint#6193)) ([745cfe4](typescript-eslint/typescript-eslint@745cfe4))- **eslint-plugin:** \[no-misused-promises] fix incorrect detection of void functions in JSX attributes ([#​6638](typescript-eslint/typescript-eslint#6638)) ([9e41cee](typescript-eslint/typescript-eslint@9e41cee))- **eslint-plugin:** \[strict-boolean-expression] support falsy and truthy literals simultaneously ([#​6672](typescript-eslint/typescript-eslint#6672)) ([62ef487](typescript-eslint/typescript-eslint@62ef487))- **eslint-plugin:** \[strict-boolean-expressions] handle truthy enums ([#​6618](typescript-eslint/typescript-eslint#6618)) ([0d0639f](typescript-eslint/typescript-eslint@0d0639f))- **eslint-plugin:** add TSPropertySignature with TSFunctionType annotation to typeMethod selector ([#​6645](typescript-eslint/typescript-eslint#6645)) ([3fc5c63](typescript-eslint/typescript-eslint@3fc5c63))##### Features- **eslint-plugin:** add allowNever support to restrict-template-expressions ([#​6554](typescript-eslint/typescript-eslint#6554)) ([423f164](typescript-eslint/typescript-eslint@423f164))### [`v5.55.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5550-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5541v5550-2023-03-13)[Compare Source](typescript-eslint/typescript-eslint@v5.54.1...v5.55.0)##### Bug Fixes- **eslint-plugin:** \[no-confusing-void-expression] check sequence expressions for void is in last position ([#​6597](typescript-eslint/typescript-eslint#6597)) ([d73d7d3](typescript-eslint/typescript-eslint@d73d7d3))- **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] fixer should handle parentheses ([#​6569](typescript-eslint/typescript-eslint#6569)) ([2d8c196](typescript-eslint/typescript-eslint@2d8c196))##### Features- **eslint-plugin:** \[lines-around-comment] add extension rule ([#​5327](typescript-eslint/typescript-eslint#5327)) ([d55211c](typescript-eslint/typescript-eslint@d55211c))- **eslint-plugin:** \[member-ordering] add support for grouping readonly fields ([#​6349](typescript-eslint/typescript-eslint#6349)) ([9d3bdfc](typescript-eslint/typescript-eslint@9d3bdfc))- **eslint-plugin:** \[no-unnecessary-cond] check logical assignments ([#​6594](typescript-eslint/typescript-eslint#6594)) ([dbc203a](typescript-eslint/typescript-eslint@dbc203a))- update TypeScript to 5.0 RC ([#​6570](typescript-eslint/typescript-eslint#6570)) ([36ef0e1](typescript-eslint/typescript-eslint@36ef0e1))- use [@​eslint-community](https://github.com/eslint-community) dependencies ([#​6603](typescript-eslint/typescript-eslint#6603)) ([5f6ed73](typescript-eslint/typescript-eslint@5f6ed73))#### [5.54.1](typescript-eslint/typescript-eslint@v5.54.0...v5.54.1) (2023-03-06)**Note:** Version bump only for package [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)### [`v5.54.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5541-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5540v5541-2023-03-06)[Compare Source](typescript-eslint/typescript-eslint@v5.54.0...v5.54.1)**Note:** Version bump only for package [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)</details><details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary>### [`v5.56.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5560-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5550v5560-2023-03-20)[Compare Source](typescript-eslint/typescript-eslint@v5.55.0...v5.56.0)**Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser)### [`v5.55.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5550-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5541v5550-2023-03-13)[Compare Source](typescript-eslint/typescript-eslint@v5.54.1...v5.55.0)##### Features- **parser:** add exported meta object ([#​6586](typescript-eslint/typescript-eslint#6586)) ([d05c3d8](typescript-eslint/typescript-eslint@d05c3d8))#### [5.54.1](typescript-eslint/typescript-eslint@v5.54.0...v5.54.1) (2023-03-06)**Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser)### [`v5.54.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5541-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5540v5541-2023-03-06)[Compare Source](typescript-eslint/typescript-eslint@v5.54.0...v5.54.1)**Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTcuMSIsInVwZGF0ZWRJblZlciI6IjM1LjE0LjEifQ==-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1811Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
PR Checklist
nevertype #5325Overview
Adds
allowNeversupport, which makes doing things like exhaustive switching easier. Uses the existing utils in the same way asallowAnydoes, and have added relevant and realistic tests.