Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): do not call export of clearProgramCache#6540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

sandersn
Copy link
Contributor

Calling it exportsundefined instead of making it an alias ofclearCaches, which I believe was the intent.

On DefinitelyTyped,I worked around the problem; clearProgramCaches isn't needed now anyway.

Calling it exports `undefined` instead of making it an alias of`clearCaches`, which I believe was the intent.
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@sandersn!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedFeb 27, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitb964b10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedFeb 27, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitb964b10
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63fd0d3678012e000826dce6
😎 Deploy Previewhttps://deploy-preview-6540--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link
Member

@bradzacherbradzacher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤦‍♂️ Thanks for this.

@bradzacherbradzacher changed the titleDo not call export of clearProgramCachefix(typescript-estree): do not call export of clearProgramCacheFeb 27, 2023
@codecov
Copy link

codecovbot commentedFeb 27, 2023•
edited
Loading

Codecov Report

Merging#6540 (b964b10) intomain (678ed41) willnot change coverage.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #6540   +/-   ##=======================================  Coverage   90.66%   90.66%           =======================================  Files         376      376             Lines       12851    12851             Branches     3783     3783           =======================================  Hits        11651    11651             Misses        856      856             Partials      344      344
FlagCoverage Δ
unittest90.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/typescript-estree/src/clear-caches.ts100.00% <100.00%> (ø)

@bradzacherbradzacher merged commit181e705 intotypescript-eslint:mainFeb 27, 2023
@sandersnsandersn deleted the do-not-call-export-of-clearProgramCache branchFebruary 27, 2023 20:36
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sandersn@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp