Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(website): change Inaccessible + text in diff codeblocks colors#6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 2 commits intotypescript-eslint:mainfromkmin-jeong:master
Mar 1, 2023

Conversation

kmin-jeong
Copy link
Contributor

@kmin-jeongkmin-jeong commentedFeb 25, 2023
edited
Loading

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloudbot commentedFeb 25, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite31f54c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kmin-jeong!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedFeb 25, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commite31f54c
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63fa09b9fc68a90008601044
😎 Deploy Previewhttps://deploy-preview-6531--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@kmin-jeongkmin-jeong changed the titlechore(website):Modify color to match web aim 4.5.chore(website):change color to match web aim.Feb 25, 2023
@kmin-jeongkmin-jeong changed the titlechore(website):change color to match web aim. chore(website):change color to match web aim.Feb 25, 2023
@kmin-jeongkmin-jeong changed the title chore(website):change color to match web aim.- chore(website):change css color to match web aim.Feb 25, 2023
@kmin-jeongkmin-jeong changed the title- chore(website):change css color to match web aim.fix:change css color to match web aim.Feb 25, 2023
@kmin-jeongkmin-jeong changed the titlefix:change css color to match web aim.feat(website): change css color to match web aim.Feb 25, 2023
@kmin-jeongkmin-jeong changed the titlefeat(website): change css color to match web aim.feat(website): change Inaccessible + text in diff codeblocks colorsFeb 25, 2023
@armano2
Copy link
Collaborator

armano2 commentedMar 1, 2023
edited
Loading

while looking at this I noticed that we have have misaligned colors for diff highlight

.code-block-added-line:before {/* ... */}.code-block-removed-line::before {/* ... */ }

I think we should change it to something like this

.code-block-removed-line::before,.code-block-added-line::before {content:'+';display: inline-block;width:0px;position: relative;left:-0.7em;}.code-block-added-line::before {color:var(--token-color-inserted);/* currently #02a471 */}.code-block-removed-line::before {color:var(--token-color-deleted);/* currently red */}

thank you for a change :)

@bradzacherbradzacher merged commite4a0a08 intotypescript-eslint:mainMar 1, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 9, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@armano2armano2armano2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Inaccessible + text in diff codeblocks
3 participants
@kmin-jeong@armano2@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp