Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): prioritize changes done in editor over hash change#6513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intomainfromfix/do-not-clear-playground-on-load-6336
Mar 1, 2023

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedFeb 22, 2023•
edited
Loading

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloudbot commentedFeb 22, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit79b0fa0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedFeb 22, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit79b0fa0
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63f6ac3e21303f0008737106
😎 Deploy Previewhttps://deploy-preview-6513--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedFeb 22, 2023•
edited
Loading

Codecov Report

Merging#6513 (79b0fa0) intomain (06b96ad) willincrease coverage by0.02%.
The diff coverage isn/a.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #6513      +/-   ##==========================================+ Coverage   90.64%   90.66%   +0.02%==========================================  Files         375      376       +1       Lines       12844    12851       +7       Branches     3782     3783       +1     ==========================================+ Hits        11642    11651       +9+ Misses        857      856       -1+ Partials      345      344       -1
FlagCoverage Δ
unittest90.66% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ript-estree/src/create-program/describeFilePath.ts100.00% <0.00%> (ø)
...-estree/src/create-program/createProjectProgram.ts97.67% <0.00%> (+4.19%)⬆️

@armano2armano2 marked this pull request as draftFebruary 22, 2023 22:42
@armano2armano2 marked this pull request as ready for reviewFebruary 23, 2023 00:01
@armano2armano2 added package: websiteIssues related to the @typescript-eslint website website: playground labelsFeb 23, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 played around with this a bunch locally and couldn't trigger the bug. Great!

@bradzacherbradzacher changed the titlefix(website): prioritize changes done in editor over hash changechore(website): prioritize changes done in editor over hash changeFeb 23, 2023
@JamesHenry
Copy link
Member

@armano2 I reported the strangeness here:quantizor/wait-for-netlify-action#5

Sadly the response is not good! There will not be any maintenance on this action going forward.

I will work on a fork over the weekend to resolve the issue

armano2 and JoshuaKGoldberg reacted with thumbs up emoji

@bradzacherbradzacher added this pull request to the merge queueMar 1, 2023
Merged via the queue intomain with commite86802dMar 1, 2023
@bradzacherbradzacher deleted the fix/do-not-clear-playground-on-load-6336 branchMarch 1, 2023 13:06
@armano2armano2 mentioned this pull requestMar 1, 2023
3 tasks
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 9, 2023
@JamesHenry
Copy link
Member

Just a follow up to my previous comment:#6513 (comment)

We now have our own lightweightwait-for-netlify action in the repo, so hopefully there should not be any more issues related to the deployment resolution (and if there are we have full control to resolve them)

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
package: websiteIssues related to the @typescript-eslint websitewebsite: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Playground clears portions of text when attempting to type
4 participants
@armano2@JamesHenry@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp