Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: clarify kinds of lint rules in formatting docs#6510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Applies a few changes to make the page more friendly for newcomers:

  • Moves theESLint Core and Formatting section to the end, so that folks start with the more-relevant explanation ofFormatters vs. Linters
  • Adds an explanation of the 2-3 categories of lint rules at the start ofESLint Core and Formatting
  • Elaborates on why you'd want to useeslint-config-prettier, as you don't actually need it unless you enable rules separate from the core/typescript-eslint recommended presets

cc@mattpocock@nzakas for interest 👋

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedFeb 21, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit8b8b644. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedFeb 21, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit8b8b644
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63f635727657ce0008facc0a
😎 Deploy Previewhttps://deploy-preview-6510--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@rubiesonthesky
Copy link
Contributor

I feel weird mentioning semicolons as just formatting, because they can affect runtime behavior. 😅 The decision between using them only where needed and always, is stylistic. Of course this is nit and it may be clear for everyone what is meant here.

@Josh-Cena
Copy link
Member

I feel weird mentioning semicolons as just formatting, because they can affect runtime behavior.

It doesn't changeruntime behavior; it changes how the code parses altogether. I guess when we say "change semicolons" it's really implied that we are changing it in a syntactically insignificant way.

JoshuaKGoldberg reacted with thumbs up emoji

bradzacher
bradzacher previously approved these changesFeb 22, 2023
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@bradzacherbradzacher merged commit3bc8c15 intotypescript-eslint:mainMar 1, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the formatting-docs-lint-rule-terminology branchMarch 1, 2023 06:02
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 9, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@rubiesontheskyrubiesontheskyrubiesonthesky left review comments

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Be more clear in differentiating "formatting" vs "style"
4 participants
@JoshuaKGoldberg@rubiesonthesky@Josh-Cena@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp