typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(website): correct crash when switching to dark/light mode in playground#6496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 3 commits intomainfromfix/playground-dark-mode

Feb 21, 2023

Merged

fix(website): correct crash when switching to dark/light mode in playground#6496

bradzacher merged 3 commits intomainfromfix/playground-dark-mode

Feb 21, 2023

Conversation

Copy link

Collaborator

armano2 commentedFeb 20, 2023•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: Playground crashes when switching between light and dark mode #6335
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

fix(website): correct crash when switching to dark/light mode in play…

e9375ca

…ground

Copy link

Contributor

typescript-eslintbot commentedFeb 20, 2023

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloudbot commentedFeb 20, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitb73c1a0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedFeb 20, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ae0e3aa`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63f3cf5d7fd3db000819e813
😎 Deploy Preview	https://deploy-preview-6496--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

armano2 commented

Feb 20, 2023

View reviewed changes

packages/website/src/components/editor/useSandboxServices.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg previously approved these changes

Feb 20, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 thanks! This seems cleaner to me.

packages/website/src/components/editor/useSandboxServices.ts OutdatedShow resolvedHide resolved

fix(website): disable jsx

b73c1a0

armano2 dismissedJoshuaKGoldberg’sstale review viab73c1a0

February 20, 2023 01:19

Copy link

codecovbot commentedFeb 20, 2023•
edited
Loading

Codecov Report

Merging#6496 (ae0e3aa) intomain (766ab1d) willincrease coverage by0.04%.
The diff coverage isn/a.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #6496      +/-   ##==========================================+ Coverage   90.61%   90.66%   +0.04%==========================================  Files         372      375       +3       Lines       12709    12841     +132       Branches     3739     3778      +39     ==========================================+ Hits        11516    11642     +126- Misses        853      854       +1- Partials      340      345       +5

Flag	Coverage Δ
unittest	`90.66% <ø> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...lugin/src/rules/consistent-generic-constructors.ts	`90.69% <0.00%> (-4.18%)`	⬇️
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts	`75.00% <0.00%> (ø)`
packages/eslint-plugin/src/rules/no-mixed-enums.ts	`94.44% <0.00%> (ø)`
packages/eslint-plugin/src/rules/block-spacing.ts	`100.00% <0.00%> (ø)`
packages/typescript-estree/src/clear-caches.ts	`100.00% <0.00%> (ø)`
...-plugin/src/rules/explicit-function-return-type.ts	`97.95% <0.00%> (+0.13%)`	⬆️
...pt-estree/src/parseSettings/createParseSettings.ts	`91.66% <0.00%> (+0.36%)`	⬆️
...ipt-estree/src/parseSettings/resolveProjectList.ts	`91.48% <0.00%> (+0.37%)`	⬆️