Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: mention re-requesting PR reviews#6493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds a mention about re-requesting review with a link to the GitHub docs. This way it's not ambiguous whether folks should wait for us.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedFeb 19, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf8e501c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedFeb 19, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf8e501c
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63f59db836f5c60008327514
😎 Deploy Previewhttps://deploy-preview-6493--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedFeb 22, 2023•
edited
Loading

Codecov Report

Merging#6493 (f8e501c) intomain (16144d1) willdecrease coverage by0.01%.
The diff coverage isn/a.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #6493      +/-   ##==========================================- Coverage   90.66%   90.66%   -0.01%==========================================  Files         374      376       +2       Lines       12823    12851      +28       Branches     3777     3783       +6     ==========================================+ Hits        11626    11651      +25- Misses        853      856       +3  Partials      344      344
FlagCoverage Δ
unittest90.66% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...lugin/src/rules/consistent-generic-constructors.ts90.69% <0.00%> (-4.18%)⬇️
packages/type-utils/src/containsAllTypesByName.ts0.00% <0.00%> (ø)
.../eslint-plugin/src/rules/promise-function-async.ts98.07% <0.00%> (ø)
packages/typescript-estree/src/clear-caches.ts100.00% <0.00%> (ø)
...ript-estree/src/create-program/describeFilePath.ts100.00% <0.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts91.66% <0.00%> (+0.36%)⬆️
...ipt-estree/src/parseSettings/resolveProjectList.ts91.48% <0.00%> (+0.37%)⬆️
...-estree/src/create-program/createProjectProgram.ts97.67% <0.00%> (+4.19%)⬆️

@bradzacherbradzacher merged commite37ebfe intotypescript-eslint:mainMar 1, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 9, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@IronGeekIronGeekIronGeek left review comments

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Mention re-requesting review in Contributing > Pull Requests
3 participants
@JoshuaKGoldberg@IronGeek@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp