Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test: allow to execute tests on windows#6488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 3 commits intov6fromfix/tests-on-windows
Feb 18, 2023

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedFeb 18, 2023
edited
Loading

Partially fix running tests on windows machines, with this change most tests do pass with exception to

expect(runSpy.mock.lastCall?.[2]).toMatchInlineSnapshot(`
{
"invalid": [
{
"code": "invalid tests should work as well",
"errors": [],
"filename": "/some/path/that/totally/exists/file.ts",
},
],
"valid": [
{
"code": "string based valid test",
"filename": "/some/path/that/totally/exists/file.ts",
},
{
"code": "object based valid test",
"filename": "/some/path/that/totally/exists/file.ts",
},
{
"code": "explicit filename shouldn't be overwritten",
"filename": "/set/in/the/test.ts",
},
{
"code": "jsx should have the correct filename",
"filename": "/some/path/that/totally/exists/file.tsx",
"parserOptions": {
"ecmaFeatures": {
"jsx": true,
},
},
},
{
"code": "type-aware parser options should override the constructor config",
"filename": "/set/in/the/test/file.ts",
"parserOptions": {
"project": "tsconfig.test-specific.json",
"tsconfigRootDir": "/set/in/the/test/",
},
},
],
}
`);
});

filename is not correctly normalized in this test, this can be fixed after updating jest to 29.4 with EqualityTesters -https://jestjs.io/docs/expect#expectaddequalitytesterstesters

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedFeb 18, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3052b2c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 26 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedFeb 18, 2023
edited
Loading

Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commit14cce83
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63f0c02f0477f00008f841dc

@armano2armano2 changed the base branch frommain tov6February 18, 2023 12:10
@armano2armano2 changed the titlefix/tests on windowstest: allow to execute tests on windowsFeb 18, 2023
@codecov
Copy link

codecovbot commentedFeb 18, 2023
edited
Loading

Codecov Report

Merging#6488 (3052b2c) intov6 (c1368f2) willincrease coverage by0.01%.
The diff coverage isn/a.

Additional details and impacted files
@@            Coverage Diff             @@##               v6    #6488      +/-   ##==========================================+ Coverage   87.11%   87.12%   +0.01%==========================================  Files         361      362       +1       Lines       12417    12474      +57       Branches     3675     3688      +13     ==========================================+ Hits        10817    10868      +51- Misses       1253     1260       +7+ Partials      347      346       -1
FlagCoverage Δ
unittest87.12% <ø> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/typescript-estree/src/convert.ts28.68% <0.00%> (-0.03%)⬇️
packages/eslint-plugin/src/rules/semi.ts100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/indent.ts92.85% <0.00%> (ø)
packages/eslint-plugin/src/rules/quotes.ts94.11% <0.00%> (ø)
packages/eslint-plugin/src/rules/typedef.ts96.00% <0.00%> (ø)
packages/type-utils/src/getContextualType.ts0.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts77.65% <0.00%> (ø)
packages/eslint-plugin/src/rules/brace-style.ts95.34% <0.00%> (ø)
packages/eslint-plugin/src/rules/key-spacing.ts99.30% <0.00%> (ø)
packages/eslint-plugin/src/rules/comma-dangle.ts93.33% <0.00%> (ø)
... and56 more

@@ -1,2 +0,0 @@
type A = typeof import('A');
type B = import('B').X<Y>;
Copy link
CollaboratorAuthor

@armano2armano2Feb 18, 2023
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

shared-fixtures has been removed in v6 and test is already correctly migrated, this is leftover from merge conflict

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As a former Windows user, I very much appreciate you sending this in 😄 thanks!

Filed#6490 too.

@JoshuaKGoldbergJoshuaKGoldberg deleted the fix/tests-on-windows branchFebruary 18, 2023 22:45
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 26, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp