Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
test: allow to execute tests on windows#6488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
nx-cloudbot commentedFeb 18, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
netlifybot commentedFeb 18, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
❌ Deploy Preview fortypescript-eslint failed.
|
codecovbot commentedFeb 18, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## v6 #6488 +/- ##==========================================+ Coverage 87.11% 87.12% +0.01%========================================== Files 361 362 +1 Lines 12417 12474 +57 Branches 3675 3688 +13 ==========================================+ Hits 10817 10868 +51- Misses 1253 1260 +7+ Partials 347 346 -1
Flags with carried forward coverage won't be shown.Click here to find out more.
|
@@ -1,2 +0,0 @@ | |||
type A = typeof import('A'); | |||
type B = import('B').X<Y>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shared-fixtures has been removed in v6 and test is already correctly migrated, this is leftover from merge conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As a former Windows user, I very much appreciate you sending this in 😄 thanks!
Filed#6490 too.
Uh oh!
There was an error while loading.Please reload this page.
Partially fix running tests on windows machines, with this change most tests do pass with exception to
typescript-eslint/packages/utils/tests/eslint-utils/rule-tester/RuleTester.test.ts
Lines 146 to 188 in98dec37
filename is not correctly normalized in this test, this can be fixed after updating jest to 29.4 with EqualityTesters -https://jestjs.io/docs/expect#expectaddequalitytesterstesters