☁️ Nx Cloud Report

CI is running/has finished running commands for commitef78d16. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 fromNxCloud.

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	ef78d16
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63efd9e8323c120008d0bb7b
😎 Deploy Preview	https://deploy-preview-6485--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Codecov Report

Merging#6485 (ef78d16) intomain (c46c793) willincrease coverage by0.02%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #6485      +/-   ##==========================================+ Coverage   90.64%   90.66%   +0.02%==========================================  Files         373      374       +1       Lines       12751    12823      +72       Branches     3752     3777      +25     ==========================================+ Hits        11558    11626      +68  Misses        853      853- Partials      340      344       +4

Won't this remove the syntax highlighting in GH because you're losing the language attribute?

I don't know if they should be seen as generated - aside from codebase reactors, we'll really want to be reviewing all of our snapshots as code because they represent the AST output.

I do have an idea for adding snapshot testing to the rule tester as well, so that would be more snapshots to be reviewed.

Won't this remove the syntax highlighting in GH because you're losing the language attribute?

No it won't.linguist-language andlinguist-generated are two orthogonal attributes. You can refer tohttps://github.com/github/linguist/blob/master/docs/overrides.md

I don't know if they should be seen as generated

You can still view the diff, just that they are collapsed by default. This prevents diffs like#6274 from being unviewable.