typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

feat(typescript-estree): expose a wrapper cache clearing function for advanced usecases#6476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 3 commits intomainfrom6462-cache-clear

Feb 20, 2023

Merged

feat(typescript-estree): expose a wrapper cache clearing function for advanced usecases#6476

bradzacher merged 3 commits intomainfrom6462-cache-clear

Feb 20, 2023

Conversation

Copy link

Member

bradzacher commentedFeb 16, 2023

PR Checklist

Addresses an existing open issue:fixesBug: repeated lints in the same process run out of memory #6462

Overview

Previously we exposed two separate functions and there were a few caches that weren't covered.

This PR exposes a single cache clear function that wraps up all our cache clearers for easy nuking.

feat(typescript-estree): expose a wrapper cache clearing function for…

34ef895

… advanced usecases

bradzacher added the enhancementNew feature or request label

Feb 16, 2023

Copy link

Contributor

typescript-eslintbot commentedFeb 16, 2023

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloudbot commentedFeb 16, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5359a68. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedFeb 16, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`5359a68`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63f31a369a6b0f0008809f13
😎 Deploy Preview	https://deploy-preview-6476--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

bradzacher mentioned this pull request

Feb 16, 2023

Bug: repeated lints in the same process run out of memory#6462

Closed

4 tasks

Copy link

codecovbot commentedFeb 16, 2023•
edited
Loading

Codecov Report

Merging#6476 (34ef895) intomain (c46c793) willincrease coverage by0.01%.
The diff coverage is100.00%.

❗ Current head34ef895 differs from pull request most recent head9fe72ef. Consider uploading reports for the commit9fe72ef to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##             main    #6476      +/-   ##==========================================+ Coverage   90.64%   90.65%   +0.01%==========================================  Files         373      374       +1       Lines       12751    12765      +14       Branches     3752     3754       +2     ==========================================+ Hits        11558    11572      +14  Misses        853      853                Partials      340      340

Flag	Coverage Δ
unittest	`90.65% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/clear-caches.ts	`100.00% <100.00%> (ø)`
...pt-estree/src/parseSettings/createParseSettings.ts	`91.66% <100.00%> (+0.36%)`	⬆️
...ipt-estree/src/parseSettings/resolveProjectList.ts	`91.48% <100.00%> (+0.37%)`	⬆️
...-plugin/src/rules/explicit-function-return-type.ts	`97.95% <0.00%> (ø)`