Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Support eslint@6#645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 7 commits intomasterfromeslint-6
Jul 21, 2019
Merged

feat: Support eslint@6#645

JamesHenry merged 7 commits intomasterfromeslint-6
Jul 21, 2019

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedJun 25, 2019•
edited
Loading

There was some weirdness around now requiring absolute paths for parser in test, but otherwise seemed to "just work"

BREAKING: dropped support for node 6

Fixes#644
Fixes#564

phts, AdamVig, dkimura, sindresorhus, Haroenv, svtslv, maxmilton, KaelWD, and limonte reacted with thumbs up emojilimonte and amaechler reacted with hooray emoji
@bradzacherbradzacher added enhancementNew feature or request dependenciesIssue about dependencies of the package labelsJun 25, 2019
@codecov

This comment has been minimized.

@bradzacher
Copy link
MemberAuthor

hmmmm this is going to be a breaking change technically, as we'll have to drop support for node v6 to run tests, unless we want to do some funky stuff with tests...

@platinumazure
Copy link
Contributor

For what it's worth, Node 6 is fully unsupported/end-of-life even by the Node team at this point.

bradzacher, jhpratt, kaicataldo, trivikr, sindresorhus, KaelWD, and repentsinner reacted with thumbs up emoji

@jhpratt

This comment has been minimized.

@bradzacher

This comment has been minimized.

@jhpratt

This comment has been minimized.

@bradzacher

This comment has been minimized.

@jhpratt

This comment has been minimized.

@trivikr

This comment has been minimized.

@bradzacher

This comment has been minimized.

@bradzacherbradzacher mentioned this pull requestJun 28, 2019
@bradzacherbradzacher added the breaking changeThis change will require a new major version to be released labelJun 28, 2019
@bradzacherbradzacher added this to the2.0.0 milestoneJun 28, 2019
@JamesHenryJamesHenry merged commit34a7cf6 intomasterJul 21, 2019
@JamesHenryJamesHenry deleted the eslint-6 branchJuly 21, 2019 17:24
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be releaseddependenciesIssue about dependencies of the packageenhancementNew feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Bump ESLint major version in Peer Dependencies (eslint 6.0) [indent-new-do-not-use] Error with ESLint 6.0.0 pre-releases
5 participants
@bradzacher@platinumazure@jhpratt@trivikr@JamesHenry
[8]ページ先頭
©2009-2025 Movatter.jp