Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore: migratedshared-fixtures
toast-spec
#6436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore: migratedshared-fixtures
toast-spec
#6436
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
nx-cloudbot commentedFeb 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
netlifybot commentedFeb 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site settings. |
codecovbot commentedFeb 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #6436 +/- ##==========================================- Coverage 91.53% 90.66% -0.87%========================================== Files 371 371 Lines 12662 12662 Branches 3721 3721 ==========================================- Hits 11590 11480 -110- Misses 754 845 +91- Partials 318 337 +19
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Let's do this:
Eg
After that I think we're in a good spot to land this? |
shared-fixtures
toast-spec
We'll also want to make sure these fixtures are automatically re-tested using the test tooling, so you'll need to updatethe test to include them |
Hmm, would you be upset if I moved |
ah yeah I guess the test isn't built to be relative to anything other than the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yas
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
shared-fixtures
tests toast-spec
fixtures #6065Overview
Migrates all the old
shared-fixtures
fixtures into the newast-spec
fixtures. Within that they're given the same folder name as their old fixture path.It would be better long-term to split these fixtures up as described in#6065:
...but there are ~375 of them, and I'd rather get them into
ast-spec
sooner. This way they'll be easier to split up later! If this PR is approved I can file a followup issue & find-and-replace the// TODO
comments in fixtures to refer to it.Most of the work in this PR was done in two steps:
327aa0c29
: Ranyarn tsx tools/migrate-fixtures.ts
to createunsorted-fixtures
from the oldshared-fixtures
bec1fe800
: Deletedshared-fixtures
altogethertools/migrate-fixtures.ts