Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: replace tsutils with ts-api-tools#6428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Usests-api-tools as a drop-in replacement fortsutils.

Note thattsutils provides someis* typeguards that are now exposed by TypeScript (e.g.ts.isBinaryExpression). I've gone ahead and switched to the TypeScript versions in this PR. Once#5573 is in we'll have CI checking to make sure our TypeScript version range supports them.

@JoshuaKGoldbergJoshuaKGoldberg added this to the6.0.0 milestoneFeb 6, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedFeb 6, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5a9d797. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewFebruary 6, 2023 03:33
@codecov
Copy link

codecovbot commentedFeb 6, 2023•
edited
Loading

Codecov Report

Merging#6428 (5a9d797) intov6 (62d5755) willdecrease coverage by0.08%.
The diff coverage is92.30%.

Additional details and impacted files
@@            Coverage Diff             @@##               v6    #6428      +/-   ##==========================================- Coverage   91.92%   91.85%   -0.08%==========================================  Files         360      360                Lines       12499    12357     -142       Branches     3701     3652      -49     ==========================================- Hits        11490    11350     -140+ Misses        707      705       -2  Partials      302      302
FlagCoverage Δ
unittest91.85% <92.30%> (-0.08%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...s/eslint-plugin/src/rules/prefer-optional-chain.ts97.48% <0.00%> (-0.02%)⬇️
packages/type-utils/src/containsAllTypesByName.ts0.00% <0.00%> (ø)
packages/type-utils/src/getContextualType.ts0.00% <0.00%> (ø)
packages/type-utils/src/predicates.ts21.73% <50.00%> (ø)
packages/eslint-plugin/src/rules/await-thenable.ts100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts96.29% <100.00%> (ø)
...t-plugin/src/rules/no-confusing-void-expression.ts100.00% <100.00%> (ø)
...kages/eslint-plugin/src/rules/no-dynamic-delete.ts100.00% <100.00%> (ø)
...es/eslint-plugin/src/rules/no-floating-promises.ts100.00% <100.00%> (ø)
...ackages/eslint-plugin/src/rules/no-implied-eval.ts96.92% <100.00%> (ø)
... and26 more

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we trust this new package? I've heard some terrible things about the maintainer.

25a.jpg

JoshuaKGoldberg reacted with thumbs down emoji
@@ -11,6 +11,7 @@ module.exports = {
'tsx',
'mts',
'mtsx',
'cjs',
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ts-api-tools formats its output files as.js with ES modules. But it also includes an additional set of.cjs files for CJS users. This allows Jest to consider.cjs files (which it didn't before) - and look at thembefore.js files.

@JoshuaKGoldberg
Copy link
MemberAuthor

Note that I renamed the package tots-api-utils inJoshuaKGoldberg/ts-api-utils#28. We don't have to take action on the rename just yet. Just a note for the next time we need to bump the package version.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 15, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp