Adds toParserServicesWithTypeInformation the two most commonly used TypeScript type checking APIs:getSymbolAtLocation andgetTypeAtLocation. Then converts all places in code that I could find that used either after immediately retrieving the TS node for an ES node.

Also applies a few standardizations that helped me find-and-replace:

const services = util.getParserServices(context) - not a variable namedparserServices, or variables from{ ... }
const checker = services.program.getTypeChecker() - not a variable namedtypeChecker ortypes, and not an intermediateprogram variable

Updates theCustom Rules docs page to reflect this.

bradzacherand others added9 commits

November 30, 2022 17:23

feat: remove partial type-information program

5ab70f1

fix docs test to handle naming-convention weirdness

3182b1c

Merge branch 'v6' into remove-partial-type-info-parse

7c9d865

review comments

a984658

fuck

932fbc3

silence useless lint logs

2a80442

feat(typescript-estree): add type checker wrapper APIs to ParserServi…

54b0d80

…cesWithTypeInformation

Add missing APIs to WebLinter

348eecf

Merge branch 'v6' into services-type-checker-wrappers

9c38389

Copy link

Contributor

typescript-eslintbot commentedJan 31, 2023

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloudbot commentedJan 31, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite7977f1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Merge branch 'v6'

506bf57

JoshuaKGoldberg mentioned this pull request

Jan 31, 2023

feat(typescript-estree): add type checker wrapper APIs to ParserServicesWithTypeInformation#6245

Closed

3 tasks

Copy link

codecovbot commentedJan 31, 2023•
edited
Loading

Codecov Report

Merging#6404 (506bf57) intov6 (1c3f470) willdecrease coverage by0.28%.
The diff coverage is97.73%.

❗ Current head506bf57 differs from pull request most recent heade7977f1. Consider uploading reports for the commite7977f1 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##               v6    #6404      +/-   ##==========================================- Coverage   91.87%   91.60%   -0.28%==========================================  Files         359      355       -4       Lines       12400    12155     -245       Branches     3653     3581      -72     ==========================================- Hits        11393    11134     -259- Misses        703      723      +20+ Partials      304      298       -6

Flag	Coverage Δ
unittest	`91.60% <97.73%> (-0.28%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...ges/type-utils/src/getConstrainedTypeAtLocation.ts	`0.00% <0.00%> (ø)`
packages/type-utils/src/getDeclaration.ts	`0.00% <0.00%> (ø)`
...ages/typescript-estree/src/createParserServices.ts	`71.42% <71.42%> (ø)`
...gin-internal/src/rules/no-poorly-typed-ts-props.ts	`87.50% <100.00%> (-1.39%)`	⬇️
...lugin-internal/src/rules/plugin-test-formatting.ts	`79.76% <100.00%> (ø)`
packages/eslint-plugin-tslint/src/rules/config.ts	`97.22% <100.00%> (ø)`
packages/eslint-plugin/src/rules/await-thenable.ts	`100.00% <100.00%> (ø)`
...eslint-plugin/src/rules/consistent-type-exports.ts	`97.67% <100.00%> (-0.03%)`	⬇️
packages/eslint-plugin/src/rules/dot-notation.ts	`96.29% <100.00%> (-0.14%)`	⬇️
...gin/src/rules/naming-convention-utils/validator.ts	`96.79% <100.00%> (-0.03%)`	⬇️
... and62 more