typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(eslint-plugin): do not use .at(), Node 14 does not support it#6402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromcoyotte508:fix-key-spacing

Jan 31, 2023

Merged

fix(eslint-plugin): do not use .at(), Node 14 does not support it#6402

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromcoyotte508:fix-key-spacing

Jan 31, 2023

Conversation

Copy link

Contributor

coyotte508 commentedJan 31, 2023

PR Checklist

Addresses an existing open issue:fixesBug: [key-spacing] Crashes on Node 14 #6396
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

fix(key-spacing): do not use .at(), Node 14 does not support it

89170cf

Copy link

Contributor

typescript-eslintbot commentedJan 31, 2023

Thanks for the PR,@coyotte508!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloudbot commentedJan 31, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf222453. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedJan 31, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`f222453`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63d93cb31336340009db88b5
😎 Deploy Preview	https://deploy-preview-6402--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

coyotte508 changed the title~~fix(key-spacing): do not use .at(), Node 14 does not support it~~fix(eslint-plugin): do not use .at(), Node 14 does not support it

Jan 31, 2023

Copy link

codecovbot commentedJan 31, 2023•
edited
Loading

Codecov Report

Merging#6402 (9b91293) intomain (fbe811c) willincrease coverage by0.00%.
The diff coverage is100.00%.

❗ Current head9b91293 differs from pull request most recent headf222453. Consider uploading reports for the commitf222453 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@##             main    #6402   +/-   ##=======================================  Coverage   91.38%   91.38%           =======================================  Files         368      368             Lines       12605    12608    +3       Branches     3712     3713    +1     =======================================+ Hits        11519    11522    +3  Misses        770      770             Partials      316      316