Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [no-import-type-side-effects] add rule to warn against runtime side effects withverbatimModuleSyntax#6394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 7 commits intomainfrom6382-rule-against-inline-type-specifiers
Feb 1, 2023

Conversation

@bradzacher
Copy link
Member

PR Checklist

Overview

Pretty straight-forward rule to implement with a fixer.

@bradzacherbradzacher added the enhancement: new plugin ruleNew rule request for eslint-plugin labelJan 31, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedJan 31, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitda7b02f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedJan 31, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitda7b02f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63d9e9a66f25590008200914
😎 Deploy Previewhttps://deploy-preview-6394--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedJan 31, 2023•
edited
Loading

Codecov Report

Merging#6394 (da7b02f) intomain (202d9fb) willincrease coverage by0.15%.
The diff coverage is91.66%.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #6394      +/-   ##==========================================+ Coverage   91.37%   91.52%   +0.15%==========================================  Files         368      371       +3       Lines       12596    12649      +53       Branches     3709     3714       +5     ==========================================+ Hits        11509    11577      +68+ Misses        772      755      -17- Partials      315      317       +2
FlagCoverage Δ
unittest91.52% <91.66%> (+0.15%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/utils/src/ts-eslint/SourceCode.ts50.00% <ø> (ø)
packages/utils/src/ast-utils/predicates.ts51.02% <50.00%> (-0.10%)⬇️
...eslint-plugin/src/rules/consistent-type-imports.ts94.50% <100.00%> (-0.04%)⬇️
...nt-plugin/src/rules/no-import-type-side-effects.ts100.00% <100.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts80.43% <0.00%> (-2.90%)⬇️
...s/eslint-plugin/src/rules/prefer-optional-chain.ts97.50% <0.00%> (-1.18%)⬇️
packages/eslint-plugin/src/util/misc.ts97.01% <0.00%> (ø)
packages/eslint-plugin/src/rules/prefer-for-of.ts91.42% <0.00%> (ø)
...ges/scope-manager/src/referencer/PatternVisitor.ts68.29% <0.00%> (ø)
...es/eslint-plugin/src/rules/prefer-function-type.ts97.18% <0.00%> (ø)
... and7 more

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesJan 31, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great! Nothing blocking from me, only suggestions (and most of them teeny nitpicks). ✨

@bradzacherbradzacher changed the titlefeat(eslint-plugin): add rule to warn against runtime side effects with verbatimModuleSyntaxfeat(eslint-plugin): [no-type-imports-with-verbatim-side-effects] add rule to warn against runtime side effects withverbatimModuleSyntaxJan 31, 2023
bradzacherand others added3 commitsFebruary 1, 2023 12:59
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>(cherry picked from commit3848375)
@bradzacherbradzacherforce-pushed the6382-rule-against-inline-type-specifiers branch from3848375 to3162d56CompareFebruary 1, 2023 02:33
@bradzacherbradzacher changed the titlefeat(eslint-plugin): [no-type-imports-with-verbatim-side-effects] add rule to warn against runtime side effects withverbatimModuleSyntaxfeat(eslint-plugin): [no-import-type-side-effects] add rule to warn against runtime side effects withverbatimModuleSyntaxFeb 1, 2023
@bradzacherbradzacher merged commitb14d3be intomainFeb 1, 2023
@bradzacherbradzacher deleted the 6382-rule-against-inline-type-specifiers branchFebruary 1, 2023 04:42
@bradzacher
Copy link
MemberAuthor

cc@DanielRosenwasser /@andrewbranch
This rule will be released next Monday.

@andrewbranch
Copy link

Awesome, thank you!

@thenbe
Copy link

thenbe commentedFeb 7, 2023•
edited
Loading

Hi. Just wondering if the following behavior in this new rule is intentional or working as intended. Currently, it's flagging allside-effect imports. Meanwhile, the docs describe the rule as:

Enforce the use of top-level import type qualifier when an importonly has specifiers with inline type qualifiers

It doesn't say anything about imports that have neithertop-level norinline type specifiers, such asside-effect imports.

If this is intentional, and this rule does act onside-effect imports, should we mention that in the docs? Else, would it make sense for this rule to have an option to not act onside-effect imports? Or is explicitly ignoring this rule for every instance the recommended approach?

Repro:https://stackblitz.com/edit/repro-side-effect-lint?file=README.md

@JoshuaKGoldberg
Copy link
Member

@ambiguous48 pleasefile an issue using one of our issue templates (I'm guessing🐛 Report a Bug With a Rule). That'll help us address it more quickly, spotlight any missing info, and help us track which version(s) bugs & fixes appear in. Thanks!

@JoshuaKGoldberg
Copy link
Member

Ah, someone already did!#6431

Which is another point in favor of using the templates. They have useful links around searching for duplicate issues.

@bradzacher
Copy link
MemberAuthor

Yup - as per our contributing guide, comments on closed PRs are not the way to ask questions or report bugs.

https://typescript-eslint.io/contributing/issues#commenting

As Josh pointed out - this bug has already been reported.

@typescript-eslinttypescript-eslint locked and limited conversation to collaboratorsFeb 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees

No one assigned

Labels

enhancement: new plugin ruleNew rule request for eslint-plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule proposal: warn against import declarations with no value specifiers and only inline type specifiers

5 participants

@bradzacher@andrewbranch@thenbe@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp