Part of my performance investigations on large codebases.
Right now we always register every single node selector in naming-convention, even if the user's config will never match that selector.

This is bad because eslint registers, parses and evaluates these selectors. All totalled these selectors combined pretty-well add up to every single identifier in the codebase!
Which is a lot of processing that's not required!

It's a simple change that can save 10s of seconds on codebases that don't use thedefault config selector.

feat(eslint-plugin): [naming-convention] improve performance by remov…

92b73a8

…ing unnecessary selectors

bradzacher added the performanceIssues regarding performance label

Jan 25, 2023

Copy link

Contributor

typescript-eslintbot commentedJan 25, 2023

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloudbot commentedJan 25, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit84767a5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedJan 25, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`84767a5`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63d979eebe0e7e00081d944c
😎 Deploy Preview	https://deploy-preview-6376--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedJan 25, 2023•
edited
Loading

Codecov Report

Merging#6376 (3a7aed3) intomain (5bf7f7f) willincrease coverage by0.12%.
The diff coverage is95.72%.

❗ Current head3a7aed3 differs from pull request most recent head84767a5. Consider uploading reports for the commit84767a5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##             main    #6376      +/-   ##==========================================+ Coverage   91.38%   91.51%   +0.12%==========================================  Files         368      368                Lines       12608    12584      -24       Branches     3713     3704       -9     ==========================================- Hits        11522    11516       -6+ Misses        770      752      -18  Partials      316      316