If a prettier update causes formatting to change (which it usually does) then right now a maintainer has to manually update the relevant renovate PR by runningyarn format locally and committing the results.

After this PR goes in, thatyarn format and commit step will be done automatically on the PR without any maintainer involvement

Copy link

Contributor

typescript-eslintbot commentedJan 23, 2023

Thanks for the PR,@JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloudbot commentedJan 23, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitcf25963. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedJan 23, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ade7707`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/647cb107d157220008663e80
😎 Deploy Preview	https://deploy-preview-6370--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

JamesHenry mentioned this pull request

Jan 23, 2023

chore(deps): update dependency prettier to v2.8.3#6323

Closed

1 task

JoshuaKGoldberg requested changes

Jan 23, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It would have been nice to get this natively in Renovate withpostUpgradeTasks but it says they're only supported in self-hosted instances 😞...

{"postUpgradeTasks": {"commands": ["yarn format"],"fileFilters": ["**/*"]  }}

But, this feels like something a lot of repos have to solve in more situations. Surely folks need this whenever they update Prettier? So it's something I think we should tackle more holistically.

What about a post-commit hook to runyarn format when the rootpackage.json changes? [their closest example, ignoring filename changes]

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Jan 23, 2023

Copy link

MemberAuthor

JamesHenry commentedJan 23, 2023

@JoshuaKGoldberg would a local hook be triggered/included in renovate's commit though?

Copy link

Member

JoshuaKGoldberg commentedJan 23, 2023

Hmm, good question. I don't actually know. Never mind me 😄

JoshuaKGoldberg previously approved these changes

Jan 23, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit: Thanks!

.github/workflows/prettier-update.yml

Comment on lines +36 to +37

		yarn --ignore-scripts
		yarn format

Copy link

Member

JoshuaKGoldbergJan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For a bit faster install, maybe?

Suggested change

	yarn --ignore-scripts
	yarn format
	npx prettier --write .

Copy link

Member

bradzacherJan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

willnpx respect thepackage.json version of prettier?

Copy link

Member

JoshuaKGoldbergJan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It goes with the latest by default, which should be what the PR is upgrading to anyway.

fisker reviewed

Mar 15, 2023

View reviewed changes

.github/workflows/prettier-update.yml OutdatedShow resolvedHide resolved

bradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs label

Mar 15, 2023

JamesHenry added2 commits

June 4, 2023 19:39

chore: add workflow to automatically run prettier when renovate updat…

236e813

…es it

chore: only commit when uncommitted changes detected

ade7707

JamesHenry dismissedJoshuaKGoldberg’sstale review viaade7707

June 4, 2023 15:43

JamesHenry force-pushed theautomated-prettier-update branch fromcf25963 toade7707Compare

June 4, 2023 15:43

Copy link

nx-cloudbot commentedJun 4, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitade7707. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets