Whilst reviewing#6084 I realised we could save some time in the parser by caching theparserOptions.project glob resolution results. So I spent a bit of time throwing this together.

I tested this locally and it saved a little bit of time (~1 second) because our glob is so small (we usepackages/*/tsconfig.json - which only matches 15 folders.
Though it's still eye-opening to see that the tiny globbing for our repo adds up to an entire second.

I double checked these results by taking a CPU profile before and after:

$ TSESTREE_SINGLE_RUN=true node --cpu-prof ./node_modules/.bin/eslint.

Then I inspected the profiles onhttps://speedscope.app
For reference - the profiles:PROFILES.zip

Before change:

After change:

I would expect that this change should show a large perf improvement in the following cases:

single-star glob that matches many directories (egpackages/*/tsconfig.json on something the size ofbabel's packages folder or bigger)
lots of globs matching all over the place (eg['foo/*/tsconfig.json', 'bar/*/tsconfig.json', 'baz/*/tsconfig.json', ...])
really any case with double star globs

bradzacher added the performanceIssues regarding performance label

Jan 23, 2023

Copy link

Contributor

typescript-eslintbot commentedJan 23, 2023

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloudbot commentedJan 23, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5e71d4b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedJan 23, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`5e71d4b`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63d97ae88ea4330008327daa
😎 Deploy Preview	https://deploy-preview-6367--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

feat(typescript-estree): cache project glob resolution

9226a45

bradzacher force-pushed thecache-glob-resolution branch from245edda to9226a45Compare

January 23, 2023 12:32

Copy link

codecovbot commentedJan 23, 2023•
edited
Loading

Codecov Report

Merging#6367 (6ec13e0) intomain (5bf7f7f) willincrease coverage by0.01%.
The diff coverage is93.15%.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #6367      +/-   ##==========================================+ Coverage   91.38%   91.40%   +0.01%==========================================  Files         368      370       +2       Lines       12608    12652      +44       Branches     3713     3723      +10     ==========================================+ Hits        11522    11564      +42- Misses        770      771       +1- Partials      316      317       +1

Flag	Coverage Δ
unittest	`91.40% <93.15%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
.../src/create-program/getWatchProgramsForProjects.ts	`79.08% <ø> (+0.68%)`	⬆️
...ges/typescript-estree/src/create-program/shared.ts	`80.43% <50.00%> (-2.90%)`	⬇️
...pescript-estree/src/parseSettings/ExpiringCache.ts	`95.23% <95.23%> (ø)`
...ipt-estree/src/parseSettings/resolveProjectList.ts	`95.55% <95.55%> (ø)`
...pt-estree/src/parseSettings/createParseSettings.ts	`97.50% <100.00%> (+0.67%)`	⬆️