I've made some small changes to test if there are any errors on the website by listening to theconsole. Added a second test with the opposite for verification. Happy to improve some more if needed.

@JoshuaKGoldberg I've made the choice not to search for a library as the tests are pretty simple and have no "magic" from the library.

Update: hmm I'm not sure what I'm doing wrong here. On my machine I don't see any issues. Am I'm missing a step if I just run the playwrih test with NX?

Copy link

nx-cloudbot commentedJan 22, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5222df7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedJan 22, 2023

Thanks for the PR,@Jefiozie!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJan 22, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`5222df7`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63d0e8f82a0162000834d3bc
😎 Deploy Preview	https://deploy-preview-6365--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Jefiozie force-pushed theaddErrorCheck branch fromf8c949e to34d5511Compare

January 22, 2023 08:09

JoshuaKGoldberg requested changes

Jan 22, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A good start! Hope this helps with the debugging, but let me know if not. 🙂

packages/website/tests/index.spec.ts OutdatedShow resolvedHide resolved

Jefiozie force-pushed theaddErrorCheck branch from34d5511 to9914120Compare

January 23, 2023 07:12

Copy link

ContributorAuthor

Jefiozie commentedJan 24, 2023•
edited by JoshuaKGoldberg
Loading

hi@JoshuaKGoldberg, I've made the requested changes, thanks for your feedback. I'm not sure why the test on CI keeps failing. Running the website project locally withnpx nx test website doesn't return the error that is descibribed in the CI test.
Do you build the website in a different way then the defaultnpx nx build website?

Copy link

Member

JoshuaKGoldberg commentedJan 24, 2023

Ooh I do get that error locally fromnpx nx website start (also when running it as aliased underyarn start)!

So this PR will have to account for that message. At least untilfacebook/docusaurus#7264 comes in.

JoshuaKGoldberg requested changes

Jan 24, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Requesting changes to get a passing build - but hey, nice to know the new test is working! 😄

packages/website/tests/index.spec.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Jan 24, 2023

test: verify that there are no errors on the website

89161e1

closes:typescript-eslint#6354

Jefiozie force-pushed theaddErrorCheck branch from0b4ac68 to89161e1Compare

January 25, 2023 07:07

Merge branch 'main' into addErrorCheck

5222df7

Jefiozie force-pushed theaddErrorCheck branch from9c63127 to5222df7Compare

January 25, 2023 08:31

Copy link

ContributorAuthor

Jefiozie commentedJan 25, 2023

So now the test are running for the website check. I'm not sure why the other tests are failing. Is this a known issue in the workflows? If I need to change anything just let me know.

Thanks for the feedback@JoshuaKGoldberg