Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.9k
feat(eslint-plugin): [no-floating-promises] error on logical expression#6356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(eslint-plugin): [no-floating-promises] error on logical expression#6356
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@islandryu! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
nx-cloudbot commentedJan 20, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
netlifybot commentedJan 20, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site settings. |
| const myPromise = async () => void 0; | ||
| const condition = true; | ||
| void (condition && myPromise()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The entire logical expression is enclosed in parentheses as in return-await.
https://typescript-eslint.io/play/#ts=4.9.3&sourceType=module&code=IYZwngdgxgBAZgV2gFwJYHsIwEbAE4AUAlDAN4wC+AsAFCiSyIoZZzrrFm0wzJ5hcaPHngCmyBHixIAJqLioIomTAA+qnPmIBubpRhRgyKAAsylWhSA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6aRfWaJ2gQwDufSvnRRE0aAHtokcGAC+IBUA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA
JoshuaKGoldberg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks! Just fix the build failure and 🚀 let's ship.
I was on the fence as to whether the suggestions should put theawait/void immediately in front of the specific promise, rather than outside the logical expression (i.e.a || (await b) rather thanawait (a || b). But since it's just suggestions, not auto-fixing, I think this is fine to keep the rule simpler.
Uh oh!
There was an error while loading.Please reload this page.
…t-eslint into featNoFloatingPromisesLogicalExpressions
codecovbot commentedFeb 3, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #6356 +/- ##======================================= Coverage 91.52% 91.52% ======================================= Files 371 371 Lines 12649 12651 +2 Branches 3714 3717 +3 =======================================+ Hits 11577 11579 +2+ Misses 755 754 -1- Partials 317 318 +1
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
islandryu commentedFeb 3, 2023
Build is cured! |
JoshuaKGoldberg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One teeeeny thing
Uh oh!
There was an error while loading.Please reload this page.
JoshuaKGoldberg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🔥
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.50.0` -> `5.51.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.50.0/5.51.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.50.0` -> `5.51.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.50.0/5.51.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary>### [`v5.51.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5510-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5500v5510-2023-02-06)[Compare Source](typescript-eslint/typescript-eslint@v5.50.0...v5.51.0)##### Bug Fixes- **eslint-plugin:** \[sort-type-constituents] fixed behavior change ([#​6384](typescript-eslint/typescript-eslint#6384)) ([5bf7f7f](typescript-eslint/typescript-eslint@5bf7f7f)), closes [#​6339](typescript-eslint/typescript-eslint#6339)- **eslint-plugin:** do not use .at(), Node 14 does not support it ([#​6402](typescript-eslint/typescript-eslint#6402)) ([077ed1b](typescript-eslint/typescript-eslint@077ed1b))##### Features- **eslint-plugin:** \[naming-convention] improve performance by removing unnecessary selectors ([#​6376](typescript-eslint/typescript-eslint#6376)) ([3647a1c](typescript-eslint/typescript-eslint@3647a1c))- **eslint-plugin:** \[no-floating-promises] error on logical expression ([#​6356](typescript-eslint/typescript-eslint#6356)) ([f330e06](typescript-eslint/typescript-eslint@f330e06))- **eslint-plugin:** \[no-import-type-side-effects] add rule to warn against runtime side effects with `verbatimModuleSyntax` ([#​6394](typescript-eslint/typescript-eslint#6394)) ([b14d3be](typescript-eslint/typescript-eslint@b14d3be))- **eslint-plugin:** \[strict-boolean-expressions] add allow nullable enum to strict boolean expressions ([#​6096](typescript-eslint/typescript-eslint#6096)) ([d4747cd](typescript-eslint/typescript-eslint@d4747cd))</details><details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary>### [`v5.51.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5510-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5500v5510-2023-02-06)[Compare Source](typescript-eslint/typescript-eslint@v5.50.0...v5.51.0)**Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMjQuMyIsInVwZGF0ZWRJblZlciI6IjM0LjEyOC4zIn0=-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1773Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
Overview
Promise in logical expression now also throws an error.