fix(eslint-plugin): handle`const;`#633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 2 commits intomasterfromempty-variable-declaration

Jun 28, 2019

Merged

fix(eslint-plugin): handle`const;`#633

bradzacher merged 2 commits intomasterfromempty-variable-declaration

Jun 28, 2019

Conversation

Copy link

Member

bradzacher commentedJun 21, 2019

Fixes#441

fix(eslint-plugin): handleconst;

b20a7d1

Fixes#441

bradzacher added the bugSomething isn't working label

Jun 21, 2019

eyedean reviewed

Jun 23, 2019

View reviewed changes

packages/eslint-plugin/src/rules/indent.ts

		@@ -175,6 +175,15 @@ export default util.createRule<Options, MessageIds>({
		}
		},

		VariableDeclaration(node: TSESTree.VariableDeclaration) {
		// https://github.com/typescript-eslint/typescript-eslint/issues/441
		if (node.declarations.length === 0) {

Copy link

eyedeanJun 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👏👏👏
I faced the exact same issue and debugging the code I was right here to add this! Thanks for being on top of it. <3@bradzacher

Merge branch 'master' into empty-variable-declaration

b9ca346

Copy link

codecovbot commentedJun 28, 2019

Codecov Report

Merging#633 intomaster willdecrease coverage by0.03%.
The diff coverage is71.42%.

@@            Coverage Diff             @@##           master     #633      +/-   ##==========================================- Coverage   94.37%   94.33%   -0.04%==========================================  Files         109      109                Lines        4535     4540       +5       Branches     1252     1254       +2     ==========================================+ Hits         4280     4283       +3- Misses        148      149       +1- Partials      107      108       +1

Impacted Files	Coverage Δ
...nt-plugin/src/rules/consistent-type-definitions.ts	`90% <ø> (ø)`	⬆️
...nt-plugin/src/rules/indent-new-do-not-use/index.ts	`98.39% <0%> (-0.53%)`	⬇️
packages/eslint-plugin/src/rules/indent.ts	`92.3% <100%> (+0.64%)`	⬆️
packages/eslint-plugin/src/rules/prefer-for-of.ts	`88.57% <100%> (ø)`	⬆️