Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(ast-spec): a JSXEmptyExpression is not a possible JSXExpression#6321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intotypescript-eslint:mainfromMageJohn:fix-6315
Jan 30, 2023

Conversation

MageJohn
Copy link
Contributor

@MageJohnMageJohn commentedJan 10, 2023•
edited
Loading

PR Checklist

Overview

As described in the linked issue, aJSXEmptyExpression node is only generated as the child of aJSXExpressionContainer node, and so cannot appear in the same place as aJSXExpression.

@nx-cloud
Copy link

nx-cloudbot commentedJan 10, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita18bab7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@MageJohn!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJan 10, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commita18bab7
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63bd504623f0b90009bd6df2
😎 Deploy Previewhttps://deploy-preview-6321--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@MageJohnMageJohn changed the titlefix(ast-spec): JSXEmptyExpression is not a possible JSXExpressionfix(ast-spec): a JSXEmptyExpression is not a possible JSXExpressionJan 10, 2023
@bradzacherbradzacher added the bugSomething isn't working labelJan 30, 2023
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks!

@bradzacherbradzacher merged commit4b27777 intotypescript-eslint:mainJan 30, 2023
@MageJohnMageJohn deleted the fix-6315 branchJanuary 31, 2023 12:33
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
bugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The JSXExpression union incorrectly includes JSXEmptyExpression
2 participants
@MageJohn@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp