Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): reorganized sidebar and header nav a bit#6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

Apropos of nothing, I feel slightly positive about this change:

  • Docs encompasses all of docs, not just theGetting Started area
  • I think people generally want to know packageArchitecture earlier than & more often thanContributing

Thoughts?

@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamJanuary 8, 2023 21:05
@nx-cloud
Copy link

nx-cloudbot commentedJan 8, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit138ff9c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJan 8, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit138ff9c
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63d8218c8e46c600081f5622
😎 Deploy Previewhttps://deploy-preview-6311--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJanuary 11, 2023 19:10
@bradzacherbradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs labelJan 30, 2023
bradzacher
bradzacher previously approved these changesJan 30, 2023
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was just thinking this today!
It felt a bit weird going via "Getting Started" to get to the maintenance docs.

@bradzacher
Copy link
Member

fix conflict them:shipit: sir

@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJan 30, 2023
@codecov
Copy link

codecovbot commentedJan 30, 2023•
edited
Loading

Codecov Report

Merging#6311 (8cbb427) intomain (4b27777) willdecrease coverage by0.10%.
The diff coverage isn/a.

❗ Current head8cbb427 differs from pull request most recent head138ff9c. Consider uploading reports for the commit138ff9c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##             main    #6311      +/-   ##==========================================- Coverage   91.37%   91.27%   -0.10%==========================================  Files         368      366       -2       Lines       12596    12445     -151       Branches     3709     3645      -64     ==========================================- Hits        11509    11359     -150  Misses        772      772+ Partials      315      314       -1
FlagCoverage Δ
unittest91.27% <ø> (-0.10%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts81.86% <0.00%> (-0.17%)⬇️
...s/eslint-plugin/src/rules/prefer-optional-chain.ts98.63% <0.00%> (-0.04%)⬇️
packages/eslint-plugin/src/rules/ban-ts-comment.ts96.96% <0.00%> (ø)
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts75.00% <0.00%> (ø)
...-plugin/src/rules/naming-convention-utils/enums.ts100.00% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/schema.ts100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/key-spacing.ts
packages/eslint-plugin/src/util/getStringLength.ts

@JoshuaKGoldbergJoshuaKGoldberg merged commitca190de intotypescript-eslint:mainJan 30, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergerepo maintenancethings to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp