Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: fix repo linting#6310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 1 commit intomainfromfix-linting
Jan 8, 2023
Merged

chore: fix repo linting#6310

JamesHenry merged 1 commit intomainfromfix-linting
Jan 8, 2023

Conversation

JamesHenry
Copy link
Member

When the renovate PR went in which upgraded the major version ofeslint-plugin-jest some issues were introduced.

  • valid-expect is triggered by some more unusual, advanced assertion we have, so we can simply ignore it
  • no-jest-import rule was removed by the plugin, so we remove it from our config

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedJan 8, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit026d5a1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedJan 8, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit026d5a1
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63bb05f495d0d500092f66ca
😎 Deploy Previewhttps://deploy-preview-6310--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JamesHenryJamesHenryenabled auto-merge (squash)January 8, 2023 18:05
@JoshuaKGoldberg
Copy link
Member

Weird how failures were able to be introduced.#6233 had a clean build. Maybe a caching issue?

@JamesHenry
Copy link
MemberAuthor

@JoshuaKGoldberg I agree, I'll raise this with the Nx team

JoshuaKGoldberg reacted with rocket emoji

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@JamesHenryJamesHenry merged commit2bdf48f intomainJan 8, 2023
@JamesHenryJamesHenry deleted the fix-linting branchJanuary 8, 2023 18:29
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JamesHenry@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp