Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
docs(eslint-plugin): remove invalid examples for unified-signatures#6286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
docs(eslint-plugin): remove invalid examples for unified-signatures#6286
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nx-cloudbot commentedDec 30, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the PR,@SuperSodaSea! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedDec 30, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense, thanks for fixing this up@SuperSodaSea! ❤️🔥
| @@ -38,6 +38,13 @@ function x(x: number | string): void; | |||
| function y(...x: number[]): void; | |||
| ``` | |||
| ```ts | |||
| // This rule won't check overload signatures with different rest parameter types. | |||
| // See https://github.com/microsoft/TypeScript/issues/5077 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a well-formatted and well-typed out comment. I like it a lot. 😄
PR Checklist
Overview
The invalid example for
unified-signatures:Is removed, and:
Is moved out of the
ignoreDifferentlyNamedParameterspart, and added comments about why the rule won't check overload signatures with different rest parameter types.