Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(website): add AST viewer test case#6275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@tapanprakasht
Copy link
Contributor

PR Checklist

Overview

Added AST viewer playwright test case.

@nx-cloud
Copy link

nx-cloudbot commentedDec 25, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit29021a7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@tapanprakasht!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedDec 25, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit9a3276d
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/642d87ab072a3000084a2713
😎 Deploy Previewhttps://deploy-preview-6275--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@tapanprakashttapanprakasht changed the titletest(website): Add AST viewer test casetest(website): add AST viewer test caseDec 25, 2022
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesDec 26, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯, thanks@tapanprakasht! This is great.

@tapanprakasht
Copy link
ContributorAuthor

tapanprakasht commentedDec 26, 2022•
edited
Loading

@JoshuaKGoldberg Thanks for checking the PR. I do face some challenges here for the test case.writeInEditor doesn't seems to be behaving as expected. I see typed text in the editor disappear automatically while running the test case which is causing the test to fail. I see the same behavior in the previous test caseUsage while running locally. Later typed text is retained in the editor. Do you face the same challenge running the test cases?

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fun!

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelDec 30, 2022
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelJan 19, 2023
@bradzacherbradzacher added the testsanything to do with testing labelJan 30, 2023
@JoshuaKGoldberg
Copy link
Member

Oh hey thanks for the reminder armano2 - ping@tapanprakasht, if you merge the latestmain into this branch I think you should be unblocked. Is there anything you're waiting for our input on?

@nx-cloud
Copy link

nx-cloudbot commentedApr 5, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit9a3276d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

@tapanprakasht
Copy link
ContributorAuthor

Oh hey thanks for the reminder armano2 - ping@tapanprakasht, if you merge the latestmain into this branch I think you should be unblocked. Is there anything you're waiting for our input on?

@JoshuaKGoldberg Updated the test cases on top the latest master branch

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wonderful, looks like all is passing! Thanks@tapanprakasht - this is great. Sorry it took so long to get it approved!

tapanprakasht reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commit75806c9 intotypescript-eslint:mainApr 5, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

+1 more reviewer

@armano2armano2armano2 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testsanything to do with testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: Add an end-to-end (Playwright) test for the playground's AST viewer

4 participants

@tapanprakasht@JoshuaKGoldberg@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp