Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree): remove optionality from AST boolean properties#6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedDec 24, 2022•
edited
Loading

PR Checklist

Overview

Switches?: boolean properties to: boolean inast-spec. Updatesconvert.ts accordingly to always assign those properties even if they're nottrue.

Does not update snapshots that need manual touchups, pending resolution of whether to use this or#6273.

@nx-cloud
Copy link

nx-cloudbot commentedDec 24, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3743f2b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 51 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

matrix_deletion

This LGTM - generate all the snapshots and we can get this in.
There's too many to review by hand, but the changes themselves are all looking good!

@JoshuaKGoldberg
Copy link
MemberAuthor

JoshuaKGoldberg commentedFeb 20, 2023•
edited
Loading

Some new test failures after merge. I'm going to take a break then look at them... this is a mildly frustrating PR to work with 🙃 ✅

@netlify
Copy link

netlifybot commentedFeb 23, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3743f2b
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63f81f90e3558300086ee6b9
😎 Deploy Previewhttps://deploy-preview-6274--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewFebruary 23, 2023 06:54
@codecov
Copy link

codecovbot commentedFeb 23, 2023•
edited
Loading

Codecov Report

Merging#6274 (3743f2b) intov6 (cbb8fed) willincrease coverage by0.74%.
The diff coverage isn/a.

Additional details and impacted files
@@            Coverage Diff             @@##               v6    #6274      +/-   ##==========================================+ Coverage   87.06%   87.81%   +0.74%==========================================  Files         365      365                Lines       12579    12455     -124       Branches     3720     3669      -51     ==========================================- Hits        10952    10937      -15+ Misses       1278     1158     -120- Partials      349      360      +11
FlagCoverage Δ
unittest87.81% <ø> (+0.74%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...-plugin/src/rules/explicit-member-accessibility.ts96.15% <0.00%> (-1.29%)⬇️
...ckages/scope-manager/src/referencer/TypeVisitor.ts97.97% <0.00%> (-1.02%)⬇️
...ackages/scope-manager/src/referencer/Referencer.ts95.49% <0.00%> (-0.43%)⬇️
packages/eslint-plugin/src/rules/indent.ts92.85% <0.00%> (ø)
...ages/eslint-plugin/src/rules/unified-signatures.ts92.10% <0.00%> (ø)
.../eslint-plugin/src/rules/no-useless-constructor.ts94.73% <0.00%> (ø)
...lugin/src/rules/consistent-indexed-object-style.ts92.06% <0.00%> (ø)
...kages/scope-manager/src/referencer/ClassVisitor.ts93.44% <0.00%> (+0.70%)⬆️
packages/typescript-estree/src/convert.ts31.86% <0.00%> (+3.66%)⬆️

@JoshuaKGoldbergJoshuaKGoldberg merged commitdf131e2 intotypescript-eslint:v6Feb 24, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the boolean-optional-remove-optional branchFebruary 24, 2023 02:51
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

AST standardisation: removeundefined/optional from node properties unless it really makes sense
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp