Movatterモバイル変換

Skip to content

typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(typescript-estree): remove false from optional AST boolean properties#6273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

JoshuaKGoldberg wants to merge1 commit intotypescript-eslint:mainfromJoshuaKGoldberg:boolean-optional-remove-false

Closed

feat(typescript-estree): remove false from optional AST boolean properties#6273

JoshuaKGoldberg wants to merge1 commit intotypescript-eslint:mainfromJoshuaKGoldberg:boolean-optional-remove-false

Conversation

JoshuaKGoldberg

Copy link

Member

JoshuaKGoldberg commentedDec 24, 2022•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesAST standardisation: removeundefined/optional from node properties unless it really makes sense #5020
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Switches most?: boolean and: boolean properties to?: true inast-spec. Updatesconvert.ts accordingly to only assign those properties if they'retrue.

Does not update snapshots that need manual touchups, pending resolution of whether to use this or#6274.

@JoshuaKGoldberg

feat(typescript-estree): remove false from optional AST boolean prope…

c8a73e4

…rties

@nx-cloud

Copy link

nx-cloudbot commentedDec 24, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitc8a73e4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
`nx run-many --target=build --all --parallel --exclude website --exclude website`

Sent with 💌 fromNxCloud.

@typescript-eslint

Copy link

Contributor

typescript-eslintbot commentedDec 24, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify

Copy link

netlifybot commentedDec 24, 2022•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

Name	Link
🔨 Latest commit	`c8a73e4`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63a6953bde76d5000856f058

This was referencedDec 24, 2022

AST standardisation: removeundefined/optional from node properties unless it really makes sense#5020

Closed

feat(typescript-estree): remove optionality from AST boolean properties#6274

Merged

@JoshuaKGoldberg

Copy link

MemberAuthor

JoshuaKGoldberg commentedJan 20, 2023

Going with#6274 per#5020 (comment).

@JoshuaKGoldberg

JoshuaKGoldberg closed this

@JoshuaKGoldberg

JoshuaKGoldberg deleted the boolean-optional-remove-false branch

January 20, 2023 00:40

@github-actions

github-actionsbot locked asresolvedand limited conversation to collaborators

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Labels

None yet

1 participant

@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp