Adds aTypeScriptIssueDetection enum so typescript-estree can be told to callprogram.getSyntacticDiagnostics(ast) but notprogram.getSemanticDiagnostics(ast).

Note that this is partially in conflict with#6066. That PR removes the partial program; this PR explicitly uses it.

It would be nice to have performance testing in place (#6218). I removed all type checking from.eslintrc.js (recommended-requiring-type-checking,deprecation/deprecation, and a few assorted rules, deleted inline commends referring to type-checked rules, and ranhyperfine "npx eslint .":

This PR, only checking syntactic diagnostics:

Time (mean ± σ): 5.763 s ± 0.103 s [User: 9.764 s, System: 0.633 s]Range (min … max): 5.707 s … 6.052 s 10 runs

This PR, checking syntactic and semantic diagnostics:

Time (mean ± σ): 6.048 s ± 0.352 s [User: 9.987 s, System: 0.666 s]Range (min … max): 5.767 s … 6.967 s 10 runs

feat: remove partial type-information program #6066:

Time (mean ± σ): 5.543 s ± 0.074 s [User: 9.191 s, System: 0.609 s]Range (min … max): 5.482 s … 5.747 s 10 runs

So, a 4% slowdown penalty for asking for syntactic diagnostics? That might just be worth it.

Either way, filedmicrosoft/TypeScript#52011 about some syntactic issues being reported as semantic diagnostics.

Competitor/sibling to#6247.

feat(typescript-estree): allow erroring on TypeScript syntactic diagn…

7d1ac25

…ostics, not semantic

Copy link

nx-cloudbot commentedDec 24, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit7d1ac25. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
`Node 14 - nx test typescript-estree --coverage=false`

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedDec 24, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.