Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [naming-convention] add support for#private modifier on class members#6259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

hlysine
Copy link
Contributor

PR Checklist

Overview

Currently, a class member with a private identifier (#private) is essentially treated as one with apublic modifier. This PR adds the#private modifier option to target this kind of member.

Numbers for TypeModifiers are changed as instructed by the comment in the Modifiers enum
@nx-cloud
Copy link

nx-cloudbot commentedDec 21, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit8c95e78. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@hlysine!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedDec 21, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit8c95e78
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63ccd0a4a281530008d6516b
😎 Deploy Previewhttps://deploy-preview-6259--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedDec 21, 2022•
edited
Loading

Codecov Report

Merging#6259 (8c95e78) intomain (503bfde) willincrease coverage by0.00%.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #6259   +/-   ##=======================================  Coverage   91.27%   91.27%           =======================================  Files         366      366             Lines       12445    12447    +2       Branches     3645     3646    +1     =======================================+ Hits        11359    11361    +2  Misses        772      772             Partials      314      314
FlagCoverage Δ
unittest91.27% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...-plugin/src/rules/naming-convention-utils/enums.ts100.00% <ø> (ø)
...plugin/src/rules/naming-convention-utils/schema.ts100.00% <ø> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts82.02% <100.00%> (+0.16%)⬆️

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks! 🚀

This rule & its tests don'tquite adhere to the same standards the rest of the codebase does, such as having one behavior under test per test case... eventually I'll have the energy to file an issue about cleaning it up. Eventually. 🫠

hlysine reacted with hooray emoji
@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)January 22, 2023 05:59
@JoshuaKGoldbergJoshuaKGoldberg merged commitc8a6d80 intotypescript-eslint:mainJan 22, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 30, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [naming-convention] add support for#private members
2 participants
@hlysine@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp