Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(typescript-estree): add type checker wrapper APIs to ParserServicesWithTypeInformation#6245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…cesWithTypeInformation
Thanks for the PR,@JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
nx-cloudbot commentedDec 18, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Note: recreated in#6404
PR Checklist
Overview
Adds to
ParserServicesWithTypeInformation
the two most commonly used TypeScript type checking APIs:getSymbolAtLocation
andgetTypeAtLocation
. Then converts all places in code that I could find that used either after immediately retrieving the TS node for an ES node.Also applies a few standardizations that helped me find-and-replace:
const services = util.getParserServices(context)
- not a variable namedparserServices
, or variables from{ ... }
const checker = services.program.getTypeChecker()
- not a variable namedtypeChecker
ortypes
, and not an intermediateprogram
variableUpdates theCustom Rules docs page to reflect this.