Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(typescript-estree): add type checker wrapper APIs to ParserServicesWithTypeInformation#6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedDec 18, 2022
edited
Loading

Note: recreated in#6404

PR Checklist

Overview

Adds toParserServicesWithTypeInformation the two most commonly used TypeScript type checking APIs:getSymbolAtLocation andgetTypeAtLocation. Then converts all places in code that I could find that used either after immediately retrieving the TS node for an ES node.

Also applies a few standardizations that helped me find-and-replace:

  • const services = util.getParserServices(context) - not a variable namedparserServices, or variables from{ ... }
  • const checker = services.program.getTypeChecker() - not a variable namedtypeChecker ortypes, and not an intermediateprogram variable

Updates theCustom Rules docs page to reflect this.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedDec 18, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit348eecf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
Node 14 - nx test eslint-plugin --coverage=false
✅ Successfully ran 45 targets

Sent with 💌 fromNxCloud.

@bradzacherbradzacher deleted the branchtypescript-eslint:remove-partial-type-info-parseJanuary 23, 2023 08:03
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 31, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp