typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

feat(eslint-plugin): [prefer-optional-chain] use type checking for strict falsiness#6240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

JoshuaKGoldberg wants to merge1 commit intotypescript-eslint:v6fromJoshuaKGoldberg:prefer-optional-chain-falsy-types

Closed

feat(eslint-plugin): [prefer-optional-chain] use type checking for strict falsiness#6240

JoshuaKGoldberg wants to merge1 commit intotypescript-eslint:v6fromJoshuaKGoldberg:prefer-optional-chain-falsy-types

Conversation

Copy link

Member

JoshuaKGoldberg commentedDec 17, 2022•
edited
Loading

BREAKING CHANGE:
Adds type checking toprefer-optional-chain

PR Checklist

Addresses an existing open issue:fixes[eslint-plugin] Breaking: enable type information for prefer-optional-chain #4820
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Uses the type checker to skip reporting a complaint when the original expression includes a falsy value that isn'tundefined.

Also adds alooseFalsiness flag to allow the old, faster behavior.

Streamlines the test file because autogenerated tests are giving me headaches.

Copy link

nx-cloudbot commentedDec 17, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit1f5c44e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedDec 17, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedDec 17, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`8d847e3`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64185a1f257dd80008580a56
😎 Deploy Preview	https://deploy-preview-6240--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

JoshuaKGoldberg marked this pull request as draft

December 17, 2022 23:21

Copy link

codecovbot commentedDec 18, 2022•
edited
Loading

Codecov Report

Merging#6240 (8d847e3) intov6 (28a64b5) willdecrease coverage by0.03%.
The diff coverage is80.95%.

Additional details and impacted files

@@            Coverage Diff             @@##               v6    #6240      +/-   ##==========================================- Coverage   85.23%   85.21%   -0.03%==========================================  Files         372      373       +1       Lines       12729    12738       +9       Branches     3783     3785       +2     ==========================================+ Hits        10850    10855       +5- Misses       1499     1502       +3- Partials      380      381       +1

Flag	Coverage Δ
unittest	`85.21% <80.95%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/type-utils/src/isTypeIntrinsic.ts	`0.00% <0.00%> (ø)`
...s/eslint-plugin/src/rules/prefer-optional-chain.ts	`95.80% <85.00%> (-1.68%)`	⬇️

... and1 file with indirect coverage changes

JoshuaKGoldberg marked this pull request as ready for review

December 18, 2022 02:46

JoshuaKGoldberg added this to the6.0.0 milestone

Dec 24, 2022

omril1 reviewed

Dec 24, 2022

View reviewed changes

packages/eslint-plugin/src/rules/prefer-optional-chain.tsShow resolvedHide resolved

JoshuaKGoldberg requested a review frombradzacher

January 19, 2023 18:18

bradzacher added the breaking changeThis change will require a new major version to be released label

Jan 30, 2023

JoshuaKGoldberg changed the base branch frommain tov6

February 25, 2023 05:32

Copy link

MemberAuthor

JoshuaKGoldberg commentedFeb 25, 2023

Lots of merge conflicts here, will need to fix up... eventually.

JoshuaKGoldberg marked this pull request as draft

February 25, 2023 05:39

bradzacher force-pushed thev6 branch 6 times, most recently from154811b to1b22295Compare

March 15, 2023 10:00

feat(eslint-plugin): [prefer-optional-chain] use type checking for st…

8d847e3

…rict falsiness

JoshuaKGoldberg force-pushed theprefer-optional-chain-falsy-types branch from1f5c44e to8d847e3Compare

March 20, 2023 13:05

Copy link

nx-cloudbot commentedMar 20, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit8d847e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets