typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

chore: enable eqeqeq internally#6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromJoshuaKGoldberg:eqeqeq

Jan 31, 2023

Merged

chore: enable eqeqeq internally#6228

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromJoshuaKGoldberg:eqeqeq

Jan 31, 2023

Conversation

Copy link

Member

JoshuaKGoldberg commentedDec 16, 2022

PR Checklist

Addresses an existing open issue:fixesRepo: Enable ESLint's eqeqeq internally #6227
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Enables the rule, allowing== null and!= null per our existing code style.

chore: enable eqeqeq internally

2183b46

Copy link

Contributor

typescript-eslintbot commentedDec 16, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloudbot commentedDec 16, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit86e1ab7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedDec 16, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`86e1ab7`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/639e76e51214a100081f0266
😎 Deploy Preview	https://deploy-preview-6228--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

JoshuaKGoldberg mentioned this pull request

Dec 16, 2022

feat(eslint-plugin): [no-unsafe-enum-assignment] add rule#6091

Closed

3 tasks

Copy link

codecovbot commentedDec 16, 2022•
edited
Loading

Codecov Report

Merging#6228 (86e1ab7) intomain (9e35ef9) willincrease coverage by0.02%.
The diff coverage is91.30%.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #6228      +/-   ##==========================================+ Coverage   91.28%   91.31%   +0.02%==========================================  Files         366      366                Lines       12445    12445                Branches     3645     3644       -1     ==========================================+ Hits        11361    11364       +3+ Misses        773      770       -3  Partials      311      311

Flag	Coverage Δ
unittest	`91.31% <91.30%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...ages/eslint-plugin/src/rules/prefer-regexp-exec.ts	`100.00% <ø> (ø)`
packages/typescript-estree/src/convert.ts	`97.13% <0.00%> (ø)`
packages/typescript-estree/src/getModifiers.ts	`60.86% <0.00%> (ø)`
...ackages/eslint-plugin/src/rules/member-ordering.ts	`96.13% <50.00%> (ø)`
...kages/eslint-plugin/src/rules/naming-convention.ts	`81.86% <50.00%> (ø)`
...t-plugin/src/rules/adjacent-overload-signatures.ts	`95.34% <100.00%> (ø)`
packages/eslint-plugin/src/rules/ban-types.ts	`100.00% <100.00%> (ø)`
packages/eslint-plugin/src/rules/comma-spacing.ts	`100.00% <100.00%> (ø)`
...gin/src/rules/naming-convention-utils/validator.ts	`96.81% <100.00%> (ø)`
...ackages/eslint-plugin/src/rules/no-implied-eval.ts	`97.05% <100.00%> (ø)`
... and23 more