Thanks for the PR,@scottarver!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

☁️ Nx Cloud Report

CI is running/has finished running commands for commitc02724c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 fromNxCloud.

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	8797d46
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/640f8c67d239b500088d641b
😎 Deploy Preview	https://deploy-preview-6193--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Codecov Report

Merging#6193 (b039619) intomain (2b2a075) willincrease coverage by6.06%.
The diff coverage is63.63%.

❗ Current headb039619 differs from pull request most recent head8797d46. Consider uploading reports for the commit8797d46 to get more accurate results

@@            Coverage Diff             @@##             main    #6193      +/-   ##==========================================+ Coverage   85.16%   91.23%   +6.06%==========================================  Files         383      366      -17       Lines       13025    12442     -583       Branches     3839     3645     -194     ==========================================+ Hits        11093    11351     +258+ Misses       1570      780     -790+ Partials      362      311      -51

👋 ping@scottarver - is this still something you have time for? No worries if not, just checking in.

☁️ Nx Cloud Report

CI is running/has finished running commands for commit8797d46. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 fromNxCloud.

Ooh, I removed some more calls and all of the unit tests are failing... but now we've got lint failures in the project itself. So we've got to add unit tests! 🙌

https://cloud.nx.app/runs/NHi3D9Xh0H

/home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin/src/rules/adjacent-overload-signatures.ts  172:18  error  Promise-returning function provided to property where a void return was expected  @typescript-eslint/no-misused-promises  173:16  error  Promise-returning function provided to property where a void return was expected  @typescript-eslint/no-misused-promises  174:22  error  Promise-returning function provided to property where a void return was expected  @typescript-eslint/no-misused-promises  175:22  error  Promise-returning function provided to property where a void return was expected  @typescript-eslint/no-misused-promises  176:24  error  Promise-returning function provided to property where a void return was expected  @typescript-eslint/no-misused-promises  177:23  error  Promise-returning function provided to property where a void return was expected  @typescript-eslint/no-misused-promises/home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin/src/rules/ban-types.ts  203:41  error  Promise-returning function provided to variable where a void return was expected  @typescript-eslint/no-misused-promises/home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin/src/rules/block-spacing.ts...

Edit:8797d46 ✅

It's worth noting that the two functions in question have different usecases.returnsThenable uses the "apparent type" which is sometimes different to the contextual type (I believe??)

Cc@jakebailey this is an example of a piece of the TS API that isn't very clear - type vs apparent type vs instantiated type vs contextual type. I couldn't find any documentation about what to use and when.

Truthfully I didn't even realize these APIs were available, let alone useful externally. Clearly, I'm wrong.

I think someone more experienced than me will have to write out explanations of those. I'll file an issue to track this request; meant to do that post-meeting but forgot.