Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-shadow] add call and method signatures toignoreFunctionTypeParameterNameValueShadow#6129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedNov 29, 2022•
edited
Loading

PR Checklist

Overview

Adds call signatures and method signatures to the node types thatno-shadow will ignore whenignoreFunctionTypeParameterNameValueShadow istrue.

I embarrassingly got this rule's logic wrong the first time I tried triaging the issues, so asking for more oversight here. 🥲

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedNov 29, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4dba7d7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedNov 29, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit4dba7d7
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/638661fae26f2f000835a43e
😎 Deploy Previewhttps://deploy-preview-6129--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(no-shadow): add call and method signatures to ignoreFunctionTypeParameterNameValueShadowfix(eslint-plugin) [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadowNov 29, 2022
@codecov
Copy link

codecovbot commentedNov 29, 2022•
edited
Loading

Codecov Report

Merging#6129 (4dba7d7) intomain (2abadc6) willincrease coverage by0.00%.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #6129   +/-   ##=======================================  Coverage   91.27%   91.27%           =======================================  Files         366      366             Lines       12417    12420    +3       Branches     3631     3632    +1     =======================================+ Hits        11333    11336    +3  Misses        774      774             Partials      310      310
FlagCoverage Δ
unittest91.27% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/rules/no-shadow.ts77.65% <100.00%> (+0.12%)⬆️
...s/eslint-plugin/src/rules/prefer-optional-chain.ts98.63% <0.00%> (+0.01%)⬆️

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin) [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadowfix(eslint-plugin): [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadowNov 29, 2022
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewNovember 29, 2022 20:07
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ramsay_good_code

JoshuaKGoldberg reacted with laugh emoji
@bradzacherbradzacher changed the titlefix(eslint-plugin): [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadowfix(eslint-plugin): [no-shadow] add call and method signatures toignoreFunctionTypeParameterNameValueShadowDec 2, 2022
@bradzacherbradzacher merged commit9d58b6b intotypescript-eslint:mainDec 2, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the no-shadow-more-function-def-types branchDecember 2, 2022 01:08
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

@Josh-CenaJosh-CenaAwaiting requested review from Josh-Cena

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [no-shadow] ignoreFunctionTypeParameterNameValueShadow = true false positive on function interface dec

2 participants

@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp