fix(eslint-plugin): [prefer-optional-chain] collect MetaProperty type#6083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromYuseiUeno:6000-fix_pref_opt_chain_meta

Nov 29, 2022

Merged

fix(eslint-plugin): [prefer-optional-chain] collect MetaProperty type#6083

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromYuseiUeno:6000-fix_pref_opt_chain_meta

Nov 29, 2022

Conversation

Copy link

Contributor

YuseiUeno commentedNov 25, 2022•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [prefer-optional-chain] Crashes when parsing animport.meta member with both the|| and! operators #6000
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Fix prefer-optional-chain cannot collect MetaProperty type bug

fix(eslint-plugin): [prefer-optional-chain] collect MetaProperty type

2a3de9c

Copy link

nx-cloudbot commentedNov 25, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commiteadef41. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedNov 25, 2022

Thanks for the PR,@YuseiUeno!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 25, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`eadef41`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63865648e1cdd6000906b688
😎 Deploy Preview	https://deploy-preview-6083--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedNov 25, 2022•
edited
Loading

Codecov Report

Merging#6083 (d01801d) intomain (76aacc0) willincrease coverage by0.00%.
The diff coverage is100.00%.

❗ Current headd01801d differs from pull request most recent headeadef41. Consider uploading reports for the commiteadef41 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@##             main    #6083   +/-   ##=======================================  Coverage   91.27%   91.27%           =======================================  Files         366      366             Lines       12417    12419    +2       Branches     3631     3632    +1     =======================================+ Hits        11333    11335    +2  Misses        774      774             Partials      310      310