test(website): add Playwright test for Playground linting#6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 2 commits intotypescript-eslint:mainfromJoshuaKGoldberg:e2e-playground-usage

Nov 25, 2022

Merged

test(website): add Playwright test for Playground linting#6080

bradzacher merged 2 commits intotypescript-eslint:mainfromJoshuaKGoldberg:e2e-playground-usage

Nov 25, 2022

Conversation

Copy link

Member

JoshuaKGoldberg commentedNov 24, 2022•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesRepo: add e2e test(s) for the website playground #5579
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Adds a playground test that:

Types passing code & enables a rule with no issues
Changes the code to fail the rule
Autofixes the code to pass again

Also fixes an accessibility oddity with labels in the visual dropdown for rules. There's no space between rule name and description currently:

await page  .getByLabel(-    '@typescript-eslint/array-typeRequire consistently using either `T[]` or `Array<T>` for arrays',+    '@typescript-eslint/array-type Require consistently using either `T[]` or `Array<T>` for arrays',  )  .check();

test(website): add Playwright test for Playground linting

a05aceb

Copy link

nx-cloudbot commentedNov 24, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitab2189b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedNov 24, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 24, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ab2189b`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/637fa844eb445d000823f82c
😎 Deploy Preview	https://deploy-preview-6080--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.