Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(typescript-estree): stub outts.SatisfiesExpression on old TS versions#6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 1 commit intomainfrompr6076
Nov 24, 2022

Conversation

@bradzacher
Copy link
Member

@bradzacherbradzacher commentedNov 24, 2022
edited
Loading

PR Checklist

Overview

Another thing we need to add to the "new syntax" contributor guide.
This union is part of the API surface for the package, so we need to ensure we don't break the build on old TS versions by "stubbing" out the new AST node types.

Also added version comments so it's easy to tell when we can remove them as we bump the minimum TS version

…ersions<!--👋 Hi, thanks for sending a PR to typescript-eslint! 💖Please fill out all fields below and make sure each item is true and [x] checked.Otherwise we may not be able to review your PR.-->## PR Checklist- [x] Steps in [CONTRIBUTING.md](https://github.com/typescript-eslint/typescript-eslint/blob/main/CONTRIBUTING.md) were taken## Overview<!-- Description of what is changed and how the code change does that. -->Another thing we need to add to the "new syntax" contributor guide.This union is part of the API surface for the package, so we need to ensure we don't break the build on old TS versions by "stubbing" out the new AST node types.Also added version comments so it's easy to tell when we can remove them as we bump the minimum TS version
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedNov 24, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf71e637. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedNov 24, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf71e637
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/637ef1ff4309110009ad9a3e
😎 Deploy Previewhttps://deploy-preview-6076--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@bradzacherbradzacher added the bugSomething isn't working labelNov 24, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TIL, thanks! Added to#5932 too.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bradzacher@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp